fix: remove code block rendering in the note section Closes #1949#1952
fix: remove code block rendering in the note section Closes #1949#1952bjohansebas merged 4 commits intoexpressjs:gh-pagesfrom
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Hi @ayush00git, thank you for opening the PR.
In _includes/admonitions/note.html, remove markdown="1" from both the <div> and <p> elements.
Also need to remove backticks (```) from all translation **/4x/api.md and `**/5x/api.md` files.
|
Hii @ShubhamOulkar, thanks for clearing the changes to me. I'll revert to this in a few minutes. |
|
Hii @ShubhamOulkar, i have removed the markdown from both div and p tags in note.html as you told me, and i didn't find any backticks in the 4x and 5x api.md to remove, they already contain plain text notes. |
I said on all translation pages not only in
See example file https://github.com/expressjs/expressjs.com/edit/gh-pages/de/4x/api.md |
|
Let me clarify, only by removing |
Ok thanks for clarifying, i'll make all these changes in a few minutes. |
|
Hii @ShubhamOulkar, i've made all the requested changes. |
ShubhamOulkar
left a comment
There was a problem hiding this comment.
Thank you @ayush00git 🙌
|
Thanks @ShubhamOulkar for your guidance throughout the issue, btw this was mine first open-source contribution. Thanks a lot ! |
|
@ayush00git keep contributing 😃 |
ShubhamOulkar
left a comment
There was a problem hiding this comment.
LGTM, all issues are resolved referenced in https://github.com/expressjs/expressjs.com/pull/1952/files#r2157968455
|
thanks @ayush00git @ShubhamOulkar! |
|
Thanks a lot @ShubhamOulkar and @bjohansebas to guide me through, that was my first open source contribution and you guys encouraged me throughout the issue and encouraged me to contribute more. |
Hii, This PR removes unnecessary code block rendering from the Express 5.0 Node.js requirement note in the 5.x api docs.
I removed backticks (```) from note sections.
Fixes #1949