chore: refactor footer and header icons#1962
Merged
bjohansebas merged 25 commits intoexpressjs:gh-pagesfrom Jul 22, 2025
Merged
chore: refactor footer and header icons#1962bjohansebas merged 25 commits intoexpressjs:gh-pagesfrom
bjohansebas merged 25 commits intoexpressjs:gh-pagesfrom
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ShubhamOulkar
added
the
maintenance
ShubhamOulkar
commented
Jul 5, 2025
ShubhamOulkar
commented
Jul 5, 2025
10 tasks
bjohansebas
reviewed
Jul 11, 2025
bjohansebas
reviewed
Jul 11, 2025
bjohansebas
reviewed
Jul 11, 2025
bjohansebas
reviewed
Jul 11, 2025
bjohansebas
reviewed
Jul 11, 2025
apply fill=currentColor on gihub and X icons Co-authored-by: Sebastian Beltran bjohansebas@gmail.com
…pressjs.com into refactor-footer
ShubhamOulkar
force-pushed
the
refactor-footer
branch
from
13a5c86 to
ad3166a
Compare
Member
Author
|
Hi @bjohansebas, Can you review this? I want to land this early as possible.🙏 |
…pressjs.com into refactor-footer
bjohansebas
reviewed
Jul 19, 2025
crandmck
approved these changes
Jul 21, 2025
Member
crandmck
left a comment
crandmck
left a comment
There was a problem hiding this comment.
LGTM, but I didn't test it comprehensively.
I trust @bjohansebas and others will do so.
bjohansebas
requested changes
Jul 21, 2025
Member
bjohansebas
left a comment
bjohansebas
left a comment
There was a problem hiding this comment.
The icons are not centered.
Member
Author
|
LGTM 
|
Member
|
thanks @ShubhamOulkar! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--box-fgfor theme toggle button.dark-mode~6 KB reduction in CSS payload