fix: add horizontal scroller on middleware table to prevent overflow on the small screen#1968
Merged
ShubhamOulkar merged 3 commits intoexpressjs:gh-pagesfrom Jul 18, 2025
Conversation
…vent overflow on mobile (expressjs#1967)
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
Hi team 👋 This PR resolves #1967 , where the middleware guide diagram was overflowing the mobile viewport and causing layout issues. Let me know if you’d prefer any adjustments or some tweaks.. |
ShubhamOulkar
requested changes
Jul 15, 2025
Member
ShubhamOulkar
left a comment
ShubhamOulkar
left a comment
There was a problem hiding this comment.
All the changes are irrelevant. Just use predefined CSS class table-scroller.
I just checked it looks good.
Contributor
Author
|
Hi @ShubhamOulkar, I’ve updated the markup to use the
Thanks! |
ShubhamOulkar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolve issue: #1967 there middleware guide contains a
tablewith animage and calloutsthat exceeds the viewport width on mobile devices, causing horizontal overflow and breaking layout.Solve
horizontal-scrollbar.mp4
This preserves the readability of the middleware diagram without distorting the layout on mobile.
Closes #1967