Skip to content

fix: add horizontal scroller on middleware table to prevent overflow on the small screen #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShubhamOulkar merged 3 commits into from
Jul 18, 2025
+5 −1
Merged

fix: add horizontal scroller on middleware table to prevent overflow on the small screen #1968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47b3671
fix(docs): add horizontal scroll wrapper to middleware diagram to pre…
Mohit5Upadhyay Jul 8, 2025
c4326ba
fix(docs): replace mw-fig-scroll with table-scroller as per review fe…
Mohit5Upadhyay Jul 15, 2025
e976cf9
apply scroller width for same cross browser behaviour
ShubhamOulkar Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1210,6 +1210,7 @@ h2 a {
.table-scroller {
width: 100%;
overflow: scroll;
scrollbar-width: thin;
}

code {
Expand Down Expand Up @@ -1443,7 +1444,8 @@ h2 a {
padding: 0;
border: 0;
width: 960px;
margin-bottom: 20px;}
margin-bottom: 20px;
}
#mw-fig-imgcell {
margin: 0;
padding: 0px;
Expand Down
2 changes: 2 additions & 0 deletions en/guide/writing-middleware.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ If the current middleware function does not end the request-response cycle, it m

The following figure shows the elements of a middleware function call:

<div class="table-scroller">
<table id="mw-fig">
<tr><td id="mw-fig-imgcell">
<img src="/images/express-mw.png" alt="Elements of a middleware function call" id="mw-fig-img" />
Expand All @@ -42,6 +43,7 @@ The following figure shows the elements of a middleware function call:
<div class="callout" id="callout6">HTTP <a href="/{{ page.lang }}/4x/api.html#req">request</a> argument to the middleware function, called "req" by convention.</div>
</td></tr>
</table>
</div>

Starting with Express 5, middleware functions that return a Promise will call `next(value)` when they reject or throw an error. `next` will be called with either the rejected value or the thrown Error.

Expand Down