docker: match GH page ruby version#1980
Merged
bjohansebas merged 1 commit intoexpressjs:gh-pagesfrom Aug 2, 2025
Merged
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jonchurch
changed the title
bjohansebas
approved these changes
Aug 2, 2025
Member
bjohansebas
left a comment
bjohansebas
left a comment
There was a problem hiding this comment.
LGTM. I hope that someday we can stop depending on GitHub Pages dependencies. That’s why we now use workflows to deploy to production and avoid relying on those versions that GitHub used. However, I’m not sure it’s worth starting to update that. I say this because, with the redesign, I’d really prefer that we migrate to another technology that we all know, since most of us know JavaScript, and we are a Node.js framework, so we know JavaScript. I have no problem continuing to wrestle with Ruby, but I’m definitely much happier developing with javascript (react, astro, nextjs, etc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
We are behind a single patch for ruby version in the dockerfile meant for local dev of the site and the
.ruby-version(used for netlify builds, or building from the directory), compared to GH pages official version.The Solution
Bump both to be 3.3.4 to be in line with GH pages.
Drop the sha pinning, to allow the dockerfile to pull the version for the correct platform.
Context
In #1916 dependabot wanted to bump the ruby version up to beyond what GH pages uses, which made me check the GH pages latest version. The goal of the dockerfile is to ease local dev, and to match the environment that GH pages uses, so I closed the dependabot PR. Dependabot will still try to update it later as patches come out unless we tell it not to. GH updates these like maybe once a year? But the GH pages version will always be behind what dependabot wants.