Fix changelog link on homepage#1982
Merged
bjohansebas merged 6 commits intoexpressjs:gh-pagesfrom Jul 27, 2025
Merged
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
bjohansebas
requested changes
Jul 22, 2025
Member
bjohansebas
left a comment
bjohansebas
left a comment
There was a problem hiding this comment.
This almost looks like a spam PR. Please use a better description and a better title. I was about to close this PR and mark it as spam, we receive a lot of spam PRs, and I thought this might be one of them.
We should keep the Express text, although we can remove the link and leave only the link to the changelog.
Contributor
Author
|
ok i will make sure from next time |
bjohansebas
reviewed
Jul 23, 2025
| <div id="homepage-leftpane" class="pane"> | ||
| <section id="description"> | ||
| <div class="express"><a href="/">Express</a><a href="{{ page.lang }}/changelog/4x.html#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div> | ||
| <div class="express"><a>Express</a><a href="{{ page.lang }}/changelog/#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div> |
Member
There was a problem hiding this comment.
Suggested change
| <div class="express"><a>Express</a><a href="{{ page.lang }}/changelog/#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div> | |
| <div class="express">Express <a href="{{ page.lang }}/changelog/#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div> |
Member
There was a problem hiding this comment.
This suggestion will fail to apply following style, since the anchor tag is removed.
#description .express > a {
color: var(--card-fg);
text-decoration: none;
}
ShubhamOulkar
requested changes
Jul 23, 2025
| <div id="homepage-leftpane" class="pane"> | ||
| <section id="description"> | ||
| <div class="express"><a href="/">Express</a><a href="{{ page.lang }}/changelog/4x.html#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div> | ||
| <div class="express"><a>Express</a><a href="{{ page.lang }}/changelog/#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div> |
Member
There was a problem hiding this comment.
Suggested change
| <div class="express"><a>Express</a><a href="{{ page.lang }}/changelog/#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div> | |
| <div class="express"><span>Express</span><a href="{{ page.lang }}/changelog/#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div> |
And update selector as #description .express > span {}
Contributor
Author
|
the required change has been done |
ShubhamOulkar
requested changes
Jul 27, 2025
Member
ShubhamOulkar
left a comment
ShubhamOulkar
left a comment
There was a problem hiding this comment.
please update selector from style.css
#description .express > a {
color: var(--card-fg);
text-decoration: none;
}
as
#description .express > span {
color: var(--card-fg);
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.