Skip to content

Fix changelog link on homepage #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjohansebas merged 6 commits into from
Jul 27, 2025
Merged

Fix changelog link on homepage #1982

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b4b65cc
"fixed the issue #1981"
antiquark007 Jul 22, 2025
cf2fc5b
Merge branch 'expressjs:gh-pages' into gh-pages
antiquark007 Jul 22, 2025
3f2e4a4
#1982 fixed link part
antiquark007 Jul 22, 2025
c98ca6c
Update index.md
antiquark007 Jul 25, 2025
f227438
Merge branch 'expressjs:gh-pages' into gh-pages
antiquark007 Jul 27, 2025
ce0d529
"done the recommended changes in style.css"
antiquark007 Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ redirect_from: "/en/index.html"
<section id="home-content">
<div id="homepage-leftpane" class="pane">
<section id="description">
<div class="express"><a href="/">Express</a><a href="{{ page.lang }}/changelog/4x.html#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div>
<div class="express"><a>Express</a><a href="{{ page.lang }}/changelog/#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div>
Copy link
Copy Markdown
Member

@bjohansebas bjohansebas Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="express"><a>Express</a><a href="{{ page.lang }}/changelog/#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div>
<div class="express">Express <a href="{{ page.lang }}/changelog/#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div>

Copy link
Copy Markdown
Member

@ShubhamOulkar ShubhamOulkar Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggestion will fail to apply following style, since the anchor tag is removed.

#description .express > a {
  color: var(--card-fg);
  text-decoration: none;
}

Copy link
Copy Markdown
Member

@ShubhamOulkar ShubhamOulkar Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="express"><a>Express</a><a href="{{ page.lang }}/changelog/#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div>
<div class="express"><span>Express</span><a href="{{ page.lang }}/changelog/#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div>

And update selector as #description .express > span {}

<h1 class="description">Fast, unopinionated, minimalist web framework for <a href='https://nodejs.org/en/'>Node.js</a></h1>
</section>
<pre class="install-command"><code>$ npm install express --save</code></pre>
Expand Down