Skip to content

Fix unclickable submenus on touchscreen tablet #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjohansebas merged 2 commits into from
Aug 1, 2025
+4 −1
Merged

Fix unclickable submenus on touchscreen tablet #1983

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb61c08
Fix unclickable submenus on touchscreen tablet
danielzgtg Jul 23, 2025
82ed780
Merge branch 'gh-pages' into fix/touchscreenNav
ShubhamOulkar Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion js/menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ let activeDrawer // active dropdown nav link


for (const el of itemsMenu) {
el.addEventListener("click", () => {
el.addEventListener("click", (e) => {
if (e.target.parentNode === el && e.pointerType === "touch" && el.querySelector("a.active")) {
Comment thread
ShubhamOulkar marked this conversation as resolved.
e.preventDefault(); // Tapping active menu on touchscreen tablet should open menu, not click
}
if (isSmallScreen || 'ontouchstart' in document.documentElement) {
// HANDLE ACTIVE LINKS IN DROPDOWN NAV
// if no activeDrawer set then page was set in md logic
Expand Down