feat : add new language picker component#2040
Merged
bjohansebas merged 14 commits intoexpressjs:gh-pagesfrom Sep 14, 2025
Merged
feat : add new language picker component#2040bjohansebas merged 14 commits intoexpressjs:gh-pagesfrom
bjohansebas merged 14 commits intoexpressjs:gh-pagesfrom
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
🚦 Lighthouse Results (Mobile & Desktop)
|
ShubhamOulkar
force-pushed
the
refactor-lang-picker
branch
from
5deaa54 to
def57d6
Compare
…ar/expressjs.com into refactor-lang-picker
ShubhamOulkar
changed the title
ShubhamOulkar
commented
Aug 31, 2025
| echo "Checking Netlify preview: $PREVIEW_URL" | ||
| for i in $(seq 1 $MAX_RETRIES); do | ||
| if curl -s --head --max-time 5 "$PREVIEW_URL" | grep "200 OK" > /dev/null; then | ||
| if curl -s -I "$PREVIEW_URL" | grep "HTTP/.* 200" > /dev/null; then |
Member
Author
There was a problem hiding this comment.
Correcting header status string. Now lighthouse audit is not running because of wrong status checking.
bjohansebas
reviewed
Sep 13, 2025
Comment on lines
-2
to
-4
| {% assign url_parts = page.url | split: '/' %} | ||
| {% assign url_remainder = url_parts | slice: 2, url_parts.size | join: '/' %} | ||
| {% assign current_lang = page.lang %} |
Member
There was a problem hiding this comment.
I think this should stay, otherwise we won’t be able to know the current URL to keep the page where it was and only change the language.
Member
Author
There was a problem hiding this comment.
Right, thank you for pointing out.
Co-authored-by: bjohansebas 103585995+bjohansebas@users.noreply.github.com
Signed-off-by: Shubham Oulkar <oulkarshubhu@gmail.com>
ShubhamOulkar
commented
Sep 14, 2025
| <ul id="navmenu"> | ||
| <li> | ||
| <a href="/" id="home-menu" {% if page.menu=='home' %} class="active" {% endif %}> | ||
| {{ site.data[page.lang].menu.home }} |
Member
Author
There was a problem hiding this comment.
Translations for this is removed. This link is redundant because express logo also points to homepage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1933 (comment)
closes #1804
cc @bjohansebas