Remove reference to unimplemented feature#2080
Closed
calebegg wants to merge 1 commit intoexpressjs:gh-pagesfrom
Closed
Remove reference to unimplemented feature#2080calebegg wants to merge 1 commit intoexpressjs:gh-pagesfrom
calebegg wants to merge 1 commit intoexpressjs:gh-pagesfrom
Conversation
path-to-regexp does not support this syntax at all. There was a PR to implement it, but it seems pretty dead. pillarjs/path-to-regexp#362
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
bjohansebas
requested changes
Nov 15, 2025
Member
bjohansebas
left a comment
bjohansebas
left a comment
There was a problem hiding this comment.
Thank you for your contribution, but unfortunately we maintain the documentation for both Express v4 and v5, so we can't remove this information that easily.
It may be confusing, and perhaps we can improve the way we present this information.
Author
|
I see. Maintaining one source of documentation for two dramatically different versions of an application seems challenging. I would suggest that y'all take a broader approach to that issue than can reasonably be addressed in one PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
path-to-regexp does not support this syntax at all. There was a PR to implement it, but it seems pretty dead. pillarjs/path-to-regexp#362