docs(express.static): add accept-ranges and cache-control options to express.static#2089
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🚦 Lighthouse Results (Mobile & Desktop)
|
| | `maxAge` | Set the max-age property of the Cache-Control header in milliseconds or a string in [ms format](https://www.npmjs.org/package/ms). | Number | 0 | | ||
| | `redirect` | Redirect to trailing "/" when the pathname is a directory. | Boolean | `true` | | ||
| | `setHeaders` | Function for setting HTTP headers to serve with the file. <br/><br/>See [setHeaders](#setHeaders) below. | Function | | | ||
| | `acceptRanges` | Enable or disable accepting ranged requests. Disabling this will not send the Accept-Ranges header and will ignore the contents of the Range request header. <br/><br/>See [acceptRanges](#acceptRanges) below. | Boolean | true | |
There was a problem hiding this comment.
Could be better to put keyword inside backticks e.g Accept-Ranges
| <h5 id='acceptRanges'>acceptRanges</h5> | ||
|
|
||
| Enable or disable accepting ranged requests, defaults to true. | ||
| Disabling this will not send `Accept-Ranges` and ignore the contents | ||
| of the `Range` request header. | ||
|
|
||
| <h5 id='cacheControl'>cacheControl</h5> | ||
|
|
||
| Enable or disable setting `Cache-Control` response header, defaults to | ||
| true. Disabling this will ignore the `immutable` and `maxAge` options. | ||
|
|
There was a problem hiding this comment.
I don't think this section adds much, as it is the exact same description we have above
Akash-2006
changed the title
|
Maybe you could put the It looks like you accidentally pushed some Gemfile changes. Other than that, looks good! |
|
i removed the changes in the Gemfile.PR description i already have the fixes and the isssue number. Can you check it and let me know if everything is good |
|
@efekrskl , Can review this and let me know of there any changes? |
|
Could you please restore your original PR title, and put the I think the PR looks good, but we'll need a team member who can merge for the final call. Hope that makes sense :) |
bjohansebas
changed the title
bjohansebas
changed the title
bjohansebas
added
docs
|
thanks @Akash-2006 |
3 participants
Added missisng accept ranges and cachecontrol in _includes/api/en/4x/express.static.md and _includes/api/en/5x/express.static.md