Skip to content

i18n: grammar pass#2339

Merged
bjohansebas merged 6 commits into
expressjs:mainfrom
jonchurch:fix-link-translations
Jun 15, 2026
Merged

i18n: grammar pass#2339
bjohansebas merged 6 commits into
expressjs:mainfrom
jonchurch:fix-link-translations

Conversation

@jonchurch

@jonchurch jonchurch commented May 20, 2026

Copy link
Copy Markdown
Member

This PR fixes some translation issues on the /resources/ page

Spefically, some relative urls were machine translated in crowdin, so this PR fixes those. Currently the links 404 bc it sends you to a non existent page

I also had claude do a pass for grammar in the languages and had it makek changes where it had high confidence.

I've already uploaded these to crowdin, but capturing them here as specific diffs in the history. After merging this, we can run the Crowdin workflow to pull down translations, and it should be a no op as crowdin should match what we have in source 🤞

@jonchurch jonchurch requested a review from a team as a code owner May 20, 2026 19:59
@netlify

netlify Bot commented May 20, 2026

Copy link
Copy Markdown

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 3879c1b
🔍 Latest deploy log https://app.netlify.com/projects/expressjscom-preview/deploys/6a2f660169c7130008065ce1
😎 Deploy Preview https://deploy-preview-2339--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@jonchurch jonchurch changed the title i18n(de): fix mistranslated URLs in de resources page i18n: fix mistranslated URLs in resources page, grammar pass May 20, 2026
@krzysdz krzysdz added bug docs Issues/pr concerning content i18n labels May 29, 2026
Fix description grammar; Glossary→Glosario; Medios→Middleware.
Ressource→Ressources (singular→plural); Glossary→Glossaire.
Glossary→Glossario (match body).
Glossary→用語集 (match body).
Fix description grammar; Expresso→Express (product name);
Glossary→Glossário; Serviços→Utilitários; Mediador→Middleware.
@bjohansebas bjohansebas force-pushed the fix-link-translations branch from d0d9b80 to 3879c1b Compare June 15, 2026 02:39
@bjohansebas bjohansebas changed the title i18n: fix mistranslated URLs in resources page, grammar pass i18n: grammar pass Jun 15, 2026
@bjohansebas bjohansebas merged commit 81c9cd0 into expressjs:main Jun 15, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug docs Issues/pr concerning content i18n

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants