[TASK] Make extensions compatible to TYPO3 v13

Author: extcode

.gitattributes

@@ -1,5 +1,4 @@
 /Build/ export-ignore
 /Tests/ export-ignore
 /.gitattributes export-ignore
-/.gitlab-ci.yml export-ignore
-/.travis.yml export-ignore
+/.gitlab-ci.yml export-ignore

.github/workflows/ci.yaml

@@ -15,7 +15,6 @@ jobs:
     strategy:
       matrix:
         php-version:
-          - 8.1
           - 8.2
           - 8.3
     steps:
@@ -41,7 +40,7 @@ jobs:
       - name: Install PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: "8.1"
+          php-version: "8.2"
           tools: composer:v2
 
       - name: Install dependencies
@@ -57,12 +56,9 @@ jobs:
     strategy:
       matrix:
         include:
-          - php-version: '8.1'
-            typo3-version: '^12.4'
           - php-version: '8.2'
-            typo3-version: '^12.4'
           - php-version: '8.3'
-            typo3-version: '^12.4'
+          - php-version: '8.4'
     steps:
       - uses: actions/checkout@v4
 
@@ -74,7 +70,9 @@ jobs:
 
       - name: Install dependencies with expected TYPO3 version
         run: |-
-          composer require --no-interaction --prefer-dist --no-progress "typo3/cms-core:${{ matrix.typo3-version }}" "typo3/cms-extbase:${{ matrix.typo3-version }}" "typo3/cms-frontend:${{ matrix.typo3-version }}"
+          composer remove --dev ssch/typo3-rector \
+          && composer require typo3/cms-install "*" \
+          && composer install --no-progress --no-ansi --no-interaction
 
       - name: Code Quality (by PHPStan)
         run: vendor/bin/phpstan analyse -c Build/phpstan.neon
@@ -91,29 +89,20 @@ jobs:
         with:
           nix_path: nixpkgs=channel:nixos-unstable
 
-      - name: Run Unit Tests PHP8.1
-        run: nix-shell --arg phpVersion \"php81\" --pure --run project-test-unit
-
       - name: Run Unit Tests PHP8.2
         run: nix-shell --arg phpVersion \"php82\" --pure --run project-test-unit
 
       - name: Run Unit Tests PHP8.3
         run: nix-shell --arg phpVersion \"php83\" --pure --run project-test-unit
 
-      - name: Run Functional Tests PHP8.1
-        run: nix-shell --arg phpVersion \"php81\" --pure --run project-test-functional
-
-      - name: Run Functional Tests PHP8.2
-        run: nix-shell --arg phpVersion \"php82\" --pure --run project-test-functional
-
-      - name: Run Functional Tests PHP8.3
-        run: nix-shell --arg phpVersion \"php83\" --pure --run project-test-functional
-
-      - name: Run Acceptance Tests PHP8.1
-        run: nix-shell --arg phpVersion \"php81\" --pure --run project-test-acceptance
+      - name: Run Unit Tests PHP8.4
+        run: nix-shell --arg phpVersion \"php84\" --pure --run project-test-unit
 
       - name: Run Acceptance Tests PHP8.2
         run: nix-shell --arg phpVersion \"php82\" --pure --run project-test-acceptance
 
       - name: Run Acceptance Tests PHP8.3
         run: nix-shell --arg phpVersion \"php83\" --pure --run project-test-acceptance
+
+      - name: Run Acceptance Tests PHP8.4
+        run: nix-shell --arg phpVersion \"php84\" --pure --run project-test-acceptance

.gitlab-ci.yml

@@ -23,32 +23,13 @@ stages:
   - documentation
 
 lint:cgl:
-  image: $CI_REGISTRY/containers/phpunit-with-php-8.1:main
+  image: $CI_REGISTRY/containers/phpunit-with-php-8.2:main
   stage: lint
   before_script:
-    - sed -i -e "s#ssh://git@code.extco.de:22722#https://gitlab-ci-token:$CI_JOB_TOKEN@code.extco.de#g" composer.json
-    - composer config platform.php 8.1
-    - composer remove typo3/cms-core --no-update
+    - composer remove typo3/cms-* --no-update
     - composer install --no-progress --no-ansi --no-interaction
   script:
     - vendor/bin/php-cs-fixer fix --config=Build/.php-cs-fixer.dist.php -v --dry-run --using-cache=no --path-mode=intersection ./
-
-lint:typoscriptcgl:
-  image: php:8.1-alpine
-  stage: lint
-  before_script:
-    - apk add --no-cache bash curl git mercurial openssh openssl parallel subversion tini zlib-dev libzip-dev zip icu-dev g++
-    - docker-php-ext-install mysqli && docker-php-ext-install zip && docker-php-ext-configure intl && docker-php-ext-install intl && docker-php-ext-enable intl
-    - wget https://composer.github.io/installer.sig -O - -q | tr -d '\n' > installer.sig
-    - php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');"
-    - php -r "if (hash_file('SHA384', 'composer-setup.php') === trim(file_get_contents('installer.sig'))) { echo 'Installer verified'; } else { echo 'Installer corrupt'; unlink('composer-setup.php'); } echo PHP_EOL;"
-    - php composer-setup.php --no-ansi --install-dir=/usr/bin --filename=composer
-    - php -r "unlink('composer-setup.php'); unlink('installer.sig');"
-    - sed -i -e "s#ssh://git@code.extco.de:22722#https://gitlab-ci-token:$CI_JOB_TOKEN@code.extco.de#g" composer.json
-    - composer config platform.php 8.1
-    - composer remove typo3/cms-core --no-update
-    - composer install --no-progress --no-ansi --no-interaction
-  script:
     - vendor/bin/typoscript-lint -c Build/typoscriptlint.yaml Configuration
 
 lint:yaml:
@@ -65,12 +46,6 @@ lint:yaml:
   script:
     - find *.php Classes Configuration Tests -name '*.php' -print0 | xargs -0 -n 1 -P 4 php -l
 
-lint:php81:
-  <<: *lint_php
-  stage: lint
-  variables:
-    CONTAINER_IMAGE: php:8.1-alpine
-
 lint:php82:
   <<: *lint_php
   variables:
@@ -82,11 +57,9 @@ lint:php83:
     CONTAINER_IMAGE: php:8.3-alpine
 
 phpstan:analyse:
-  image: $CI_REGISTRY/containers/phpunit-with-php-8.1:main
+  image: $CI_REGISTRY/containers/phpunit-with-php-8.2:main
   stage: lint
   before_script:
-    - sed -i -e "s#ssh://git@code.extco.de:22722#https://gitlab-ci-token:$CI_JOB_TOKEN@code.extco.de#g" composer.json
-    - composer config platform.php 8.1
     - composer install --no-progress --no-ansi --no-interaction
   script:
     - vendor/bin/phpstan analyse -c Build/phpstan.neon --memory-limit 256M
@@ -99,84 +72,67 @@ phpstan:analyse:
   only:
     - branches
   before_script:
-    - composer config --no-plugins allow-plugins.typo3/cms-composer-installers true
-    - composer config --no-plugins allow-plugins.typo3/class-alias-loader true
-    - composer require typo3/cms-core="${TYPO3_VERSION}"
+    - composer install --no-progress --no-ansi --no-interaction
   script:
     - vendor/bin/phpunit -c Build/UnitTests.xml
-    - typo3DatabaseDriver=pdo_sqlite vendor/bin/phpunit -c Build/FunctionalTests.xml
 
-# Build in PHP 8.1 and TYPO3 12.4
-test:php81:typo3_12:
+test:phpunit.php82:
   <<: *test_php
   variables:
-    CONTAINER_IMAGE: $CI_REGISTRY/containers/phpunit-with-php-8.1:main
-    TYPO3_VERSION: ^12.4
+    CONTAINER_IMAGE: $CI_REGISTRY/containers/phpunit-with-php-8.2:main
 
-# Build in PHP 8.2 and TYPO3 12.4
-test:php82:typo3_12:
+test:phpunit.php83:
   <<: *test_php
   variables:
-    CONTAINER_IMAGE: $CI_REGISTRY/containers/phpunit-with-php-8.2:main
-    TYPO3_VERSION: ^12.4
+    CONTAINER_IMAGE: $CI_REGISTRY/containers/phpunit-with-php-8.3:main
 
-# Build in PHP 8.3 and TYPO3 12.4
-test:php83:typo3_12:
+test:phpunit.php84:
   <<: *test_php
   variables:
-    CONTAINER_IMAGE: $CI_REGISTRY/containers/phpunit-with-php-8.3:main
-    TYPO3_VERSION: ^12.4
+    CONTAINER_IMAGE: $CI_REGISTRY/containers/phpunit-with-php-8.4:main
 
 .test_codeception: &test_codeception
   stage: test
   image: $CONTAINER_IMAGE
   only:
     - branches
   before_script:
-    - sed -i -e "s#ssh://git@code.extco.de:22722#https://gitlab-ci-token:$CI_JOB_TOKEN@code.extco.de#g" composer.json
-    - composer config --no-plugins allow-plugins.typo3/cms-composer-installers true
-    - composer config --no-plugins allow-plugins.typo3/class-alias-loader true
-    - composer require typo3/cms-core="${TYPO3_VERSION}"
+    - composer install --no-progress --no-ansi --no-interaction
   script:
     - mkdir -p .build/public/typo3temp/var/tests/acceptance-sqlite-dbs
     - export typo3DatabaseDriver=pdo_sqlite
     - export PROJECT_ROOT="$(pwd)"
     - export INSTANCE_PATH="$(pwd)/.build/web/typo3temp/var/tests/acceptance"
     - mkdir -p "$INSTANCE_PATH"
     - mkdir -p "$PROJECT_ROOT/.build/web/typo3temp/var/tests/acceptance-logs/"
+    - vendor/bin/codecept build
     - vendor/bin/codecept run
   artifacts:
     paths:
       - .build
     expire_in: 1 day
     when: always
 
-# Build in PHP 8.1 and TYPO3 12.4
-test:codception:php81:typo3_12:
+test:codeception:php82:
   <<: *test_codeception
   variables:
-    CONTAINER_IMAGE: $CI_REGISTRY/containers/codeception-with-php-8.1:main
-    TYPO3_VERSION: ^12.4
+    CONTAINER_IMAGE: $CI_REGISTRY/containers/codeception-with-php-8.2:main
     GECKODRIVER_VERSION: v0.34.0
 
-# Build in PHP 8.2 and TYPO3 12.4
-test:codception:php82:typo3_12:
+test:codeception:php83:
   <<: *test_codeception
   needs:
-    - test:codception:php81:typo3_12
+    - test:codeception:php82
   variables:
-    CONTAINER_IMAGE: $CI_REGISTRY/containers/codeception-with-php-8.2:main
-    TYPO3_VERSION: ^12.4
+    CONTAINER_IMAGE: $CI_REGISTRY/containers/codeception-with-php-8.3:main
     GECKODRIVER_VERSION: v0.34.0
 
-# Build in PHP 8.3 and TYPO3 12.4
-test:codception:php83:typo3_12:
+test:codeception:php84:
   <<: *test_codeception
   needs:
-    - test:codception:php82:typo3_12
+    - test:codeception:php83
   variables:
-    CONTAINER_IMAGE: $CI_REGISTRY/containers/codeception-with-php-8.3:main
-    TYPO3_VERSION: ^12.4
+    CONTAINER_IMAGE: $CI_REGISTRY/containers/codeception-with-php-8.4:main
     GECKODRIVER_VERSION: v0.34.0
 
 documentation:

Build/FunctionalTests.xml

@@ -1,5 +1,21 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="true" bootstrap="../vendor/typo3/testing-framework/Resources/Core/Build/FunctionalTestsBootstrap.php" colors="true" stopOnError="false" stopOnFailure="false" stopOnIncomplete="false" stopOnSkipped="false" beStrictAboutTestsThatDoNotTestAnything="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.1/phpunit.xsd" cacheDirectory=".phpunit.cache" requireCoverageMetadata="false">
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.1/phpunit.xsd"
+         backupGlobals="true"
+         beStrictAboutTestsThatDoNotTestAnything="false"
+         bootstrap="../vendor/typo3/testing-framework/Resources/Core/Build/FunctionalTestsBootstrap.php"
+         cacheResult="false"
+         colors="true"
+         failOnDeprecation="true"
+         failOnWarning="true"
+         failOnRisky="true"
+         processIsolation="false"
+         requireCoverageMetadata="false"
+         stopOnError="false"
+         stopOnFailure="false"
+         stopOnIncomplete="false"
+         stopOnSkipped="false"
+>
   <coverage/>
   <testsuites>
     <testsuite name="Cart Books Extension">

Build/UnitTests.xml

@@ -1,5 +1,21 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="true" bootstrap="../vendor/typo3/testing-framework/Resources/Core/Build/UnitTestsBootstrap.php" colors="true" processIsolation="false" stopOnError="false" stopOnFailure="false" stopOnIncomplete="false" stopOnSkipped="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.1/phpunit.xsd" cacheDirectory=".phpunit.cache" backupStaticProperties="false" requireCoverageMetadata="false">
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.1/phpunit.xsd"
+         backupGlobals="true"
+         beStrictAboutTestsThatDoNotTestAnything="false"
+         bootstrap="../vendor/typo3/testing-framework/Resources/Core/Build/UnitTestsBootstrap.php"
+         cacheResult="false"
+         colors="true"
+         failOnDeprecation="true"
+         failOnWarning="true"
+         failOnRisky="true"
+         processIsolation="false"
+         requireCoverageMetadata="false"
+         stopOnError="false"
+         stopOnFailure="false"
+         stopOnIncomplete="false"
+         stopOnSkipped="false"
+>
   <coverage/>
   <testsuites>
     <testsuite name="Cart Books Extension">