Skip to content

Commit a74581e

Browse files
committed
fix: pull_request_template.md
Signed-off-by: Daniel Engbert <end1@umbc.edu>
1 parent 5e4fce9 commit a74581e

2 files changed

Lines changed: 11 additions & 2 deletions

File tree

.github/pull_request_template.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,4 @@ How do you like to solve the issue and why?
1515
- [ ] I have read the [contribution guidelines](https://external-secrets.io/latest/contributing/process/#submitting-a-pull-request)
1616
- [ ] All commits are signed with `git commit --signoff`
1717
- [ ] My changes have reasonable test coverage
18-
- [ ] All tests pass with `make test`
19-
- [ ] I ensured my PR is ready for review with `make reviewable`
18+
- [ ] All tests pass with `make test-ci`

docs/contributing/devguide.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,13 @@ break funcs listSecretsHandler
2424
# and start code execution
2525
continue
2626
````
27+
28+
## Unit Tests
29+
30+
````bash
31+
# run test suite
32+
make test-ci
33+
34+
# if you're on mac run
35+
CGO_LDFLAGS="-framework CoreFoundation" CGO_ENABLED=1 go test ./... -coverprofile cover.out
36+
````

0 commit comments

Comments
 (0)