externpro 26.01-31-g46d8703#342
Merged
Merged
Conversation
- Remove hardcoded library variables for fmt and spdlog
- Add fallback target detection for ${pro} and ${pro}::${pro}
- Fix conditional compilation blocks for toda executable
- Update argon2 library removal to use target name instead of variable
These changes make the test build more robust by supporting multiple
target naming conventions and ensuring proper conditional compilation.
…ffers - Conditionally include xpflatbuffers.cmake when available - Including xpflatbuffers.cmake when cmake script isn't used (cps file found/used) - Add flexible target detection for flatbuffers (cps) and flatbuffers::flatbuffers (cmake) - Replace hardcoded xpro::flatbuffers with detected target - Improve compatibility with different flatbuffers installations This change allows the test to work with both traditional CMake targets and CPS targets.
smanders
added
dependencies
smanders
force-pushed
the
xpupdate-26.01-31-g46d8703-25941940520-1
branch
from
ce029a6 to
335ea99
Compare
- Prioritize TARGET detection over LIBRARIES variables for better CPS support
- Move ${PRJ}_LIBRARIES check to end as fallback option
- This allows CPS targets to be detected before legacy library variables
- fmt and spdlog on Windows use cmake config (not CPS), which has LIBRARIES var
- [fmt|spdlog]-header-only libraries cause multiply-defined linker errors
- rather than 'set([fmt|spd]_libs' again, bump LIBRARIES to the end
Improves compatibility with modern CPS-based package consumption
while maintaining fallback to traditional library variable approach.
smanders
force-pushed
the
xpupdate-26.01-31-g46d8703-25941940520-1
branch
from
335ea99 to
62ac372
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update externpro submodule to
26.01-31-g46d8703Changes
.devcontainerto externpro26.01-31-g46d870385b061cd68a2c33da811e8eef71ef55501240e9c46d8703adaf9d9771b339d32969d51a460fbb68bd4fc376849bed03b867b471d84e3000c82e93abdmain)Workflow Update Report
jobs.linux.with.buildpro_imagesThis PR was created automatically by GitHub Actions