fix: address PR review comments

- Bump coverage thresholds from 70% to 80% in bunfig.toml
- Fix shebang regex over-matching by removing multiline flag in build.ts
- Add console.warn for silent catch in getExternalDependencies
- Make second shebang regex more conservative for bundled modules
- Use turbo:build in CI workflow to build all workspace packages
- Add actions:write permission to release workflow for workflow dispatch
- Use targeted signal listener cleanup in test setup

Author: Crunchyman-ralph

.github/workflows/ci.yml

@@ -174,7 +174,7 @@ jobs:
         timeout-minutes: 5
 
       - name: Build
-        run: bun run build
+        run: bun run turbo:build
         env:
           NODE_ENV: production
           FORCE_COLOR: 1

.github/workflows/release.yml

@@ -12,6 +12,7 @@ permissions:
   contents: write
   pull-requests: write
   id-token: write
+  actions: write
 
 env:
   BUN_VERSION: 1.2.6

bunfig.toml

@@ -9,7 +9,7 @@ preload = ["./tests/setup.ts"]
 coverage = true
 
 # Coverage thresholds
-coverageThreshold = { line = 70, function = 70, statement = 70 }
+coverageThreshold = { line = 80, function = 80, statement = 80 }
 
 # Test timeouts
 timeout = 10000

scripts/build.ts

@@ -101,7 +101,8 @@ function getExternalDependencies(): string[] {
 		];
 		// Keep npm packages external, but bundle @tm/* workspace packages
 		return allDeps.filter((dep) => !dep.startsWith('@tm/'));
-	} catch {
+	} catch (error) {
+		console.warn('Could not read package.json for external dependencies:', error);
 		return [];
 	}
 }
@@ -149,9 +150,9 @@ const taskMasterPath = join(distDir, 'task-master.js');
 function ensureShebang(content: string): string {
 	const shebang = '#!/usr/bin/env node\n';
 	// Remove any existing shebangs (there might be multiple from bundling)
-	let cleaned = content.replace(/^(#!.*\n)+/gm, '');
-	// Also handle shebangs that appear after the first line
-	cleaned = cleaned.replace(/\n#!\/usr\/bin\/env node\n/g, '\n');
+	let cleaned = content.replace(/^(#!.*\n)+/, '');
+	// Also handle shebangs that appear after the first line (from bundled modules)
+	cleaned = cleaned.replace(/\n(#!\/usr\/bin\/env node\n)+/g, '\n');
 	return shebang + cleaned;
 }
 

tests/setup.ts

@@ -61,15 +61,26 @@ if (process.env.SILENCE_CONSOLE === 'true') {
 	};
 }
 
+// Track original listener counts to restore only what we added
+const originalListenerCounts: Record<string, number> = {
+	SIGINT: process.listenerCount('SIGINT'),
+	SIGTERM: process.listenerCount('SIGTERM'),
+	SIGHUP: process.listenerCount('SIGHUP'),
+};
+
 // Clean up signal-exit listeners after all tests to prevent open handle warnings
 // This is needed because packages like proper-lockfile register signal handlers
 afterAll(async () => {
 	// Give any pending async operations time to complete
 	await new Promise((resolve) => setImmediate(resolve));
 
-	// Clean up any registered signal handlers from signal-exit
-	const listeners = ['SIGINT', 'SIGTERM', 'SIGHUP'] as const;
-	for (const signal of listeners) {
-		process.removeAllListeners(signal);
+	// Remove only listeners added after setup, preserving framework/application listeners
+	for (const [signal, originalCount] of Object.entries(originalListenerCounts)) {
+		const currentListeners = process.listeners(signal as NodeJS.Signals);
+		const addedCount = currentListeners.length - originalCount;
+		for (let i = 0; i < addedCount; i++) {
+			const listener = currentListeners[currentListeners.length - 1 - i];
+			process.removeListener(signal, listener as (...args: unknown[]) => void);
+		}
 	}
 });