EZP-28243: Purge type using service id does not work#2136
Conversation
|
So, may I just remove the offended test which complains since we no longer throws exception on unknown purge_types ( this is instead done by ezplatform-http-cache) |
|
Do you need this on older releases as well? (thinking cases where people don't use ezplatform-http-cache also), or do we aim to require ezplatform-http-cache? (ok with me) EDIT: We also need an JIRA issue covering this change and the change in ezplatform-http-cache
If we go with this, then yes. But ideally we should somehow still throw for people not using |
|
I basically need this in every version where we are going to support fastly.... Fastly support will require ezplatform-http-cache |
So, this is heading for 1.13.0 where ezplatform-http-cache is going to be enabled by default. |
Actually v1.12.1 and up, ezplatform-http-cache was enabled by default in 1.12 |
|
We should merge #2123 so you can run |
|
hehe. I am not against #2123.... |
41c97cb to
d22e1fa
Compare
59f1250 to
6791153
Compare
|
Github won't have me review and approve this PR as I created it. My commits should be removed before merged though |
we always squash now by default, and when not we rebase :) |
6791153 to
5b45826
Compare
Uh oh!
There was an error while loading. Please reload this page.