Skip to content

EZP-28243: Purge type using service id does not work#2136

Merged
andrerom merged 2 commits into
6.7from
purge_type_from_external_bundles
Nov 16, 2017
Merged

EZP-28243: Purge type using service id does not work#2136
andrerom merged 2 commits into
6.7from
purge_type_from_external_bundles

Conversation

@vidarl

@vidarl vidarl commented Nov 2, 2017

Copy link
Copy Markdown
Member

Issue: https://jira.ez.no/browse/EZP-28243

  1. Fixes so it is possible to use this setting as documented in semantic config help text.
  2. Make it possible to add plugin system for ezplatform-http-cache in order to add Fasly support: EZEE-1780: Plugin support ezplatform-http-cache#19

@vidarl

vidarl commented Nov 2, 2017

Copy link
Copy Markdown
Member Author

So, may I just remove the offended test which complains since we no longer throws exception on unknown purge_types ( this is instead done by ezplatform-http-cache)

@andrerom

andrerom commented Nov 2, 2017

Copy link
Copy Markdown
Contributor

Do you need this on older releases as well? (thinking cases where people don't use ezplatform-http-cache also), or do we aim to require ezplatform-http-cache? (ok with me)

EDIT: We also need an JIRA issue covering this change and the change in ezplatform-http-cache

So, may I just remove the offended test which complains since we no longer throws exception on unknown purge_types

If we go with this, then yes. But ideally we should somehow still throw for people not using ezplatform-http-cache

@vidarl

vidarl commented Nov 2, 2017

Copy link
Copy Markdown
Member Author

I basically need this in every version where we are going to support fastly.... Fastly support will require ezplatform-http-cache
Update : we'll need this for 2.0.0 and 1.13.0

@vidarl

vidarl commented Nov 3, 2017

Copy link
Copy Markdown
Member Author

If we go with this, then yes. But ideally we should somehow still throw for people not using ezplatform-http-cache

So, this is heading for 1.13.0 where ezplatform-http-cache is going to be enabled by default.
Should I still write a check if the ezplatform-http-cache bundle is installed?

@andrerom

andrerom commented Nov 6, 2017

Copy link
Copy Markdown
Contributor

Update : we'll need this for 2.0.0 and 1.13.0

Actually v1.12.1 and up, ezplatform-http-cache was enabled by default in 1.12

@vidarl vidarl changed the title Fixed so that it possible to define purge_type in other bundles [WIP] Fixed so that it possible to define purge_type in other bundles Nov 8, 2017
@alongosz

alongosz commented Nov 8, 2017

Copy link
Copy Markdown
Member

We should merge #2123 so you can run composer fix-cs before pushing ;)

@vidarl

vidarl commented Nov 8, 2017

Copy link
Copy Markdown
Member Author

hehe. I am not against #2123....

@ezsystems ezsystems deleted a comment from ezrobot Nov 14, 2017
@andrerom andrerom force-pushed the purge_type_from_external_bundles branch 3 times, most recently from 41c97cb to d22e1fa Compare November 15, 2017 22:11
@andrerom andrerom changed the base branch from master to 6.12 November 15, 2017 22:11
@ezsystems ezsystems deleted a comment from ezrobot Nov 16, 2017
@andrerom andrerom changed the title [WIP] Fixed so that it possible to define purge_type in other bundles EZP-28243: Purge type using service id does not work Nov 16, 2017
@andrerom andrerom changed the base branch from 6.12 to 6.7 November 16, 2017 10:45
@andrerom andrerom force-pushed the purge_type_from_external_bundles branch from 59f1250 to 6791153 Compare November 16, 2017 10:45
@andrerom andrerom self-assigned this Nov 16, 2017
@vidarl

vidarl commented Nov 16, 2017

Copy link
Copy Markdown
Member Author

Github won't have me review and approve this PR as I created it.
But I do approve your commits AR...

My commits should be removed before merged though

@andrerom

andrerom commented Nov 16, 2017

Copy link
Copy Markdown
Contributor

My commits should be removed before merged though

we always squash now by default, and when not we rebase :)

@andrerom andrerom force-pushed the purge_type_from_external_bundles branch from 6791153 to 5b45826 Compare November 16, 2017 11:01
@andrerom andrerom merged commit 5b45826 into 6.7 Nov 16, 2017
@andrerom andrerom deleted the purge_type_from_external_bundles branch November 16, 2017 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants