Ease Of Life#277
Conversation
hrjakobsen
left a comment
There was a problem hiding this comment.
This would add 0.0.0.0 to the allowed hosts on the production server as well, which I don't think we want.
Does the production server use local.cfg.skel? I would expect that we have previously made a local.cfg that is not tracked in git (https://github.com/f-klubben/stregsystemet/blob/next/.gitignore#L4) that it uses. I don't have access to the server anymore (since AAU closed all port 22 connections) The local.cfg.skel is just a skeleton for new users to have a start for their own local.cfg file. I could be wrong, but I think changing this file in the repo is fine. |
|
@VirtualSatai previously the PR changed |
hrjakobsen
left a comment
There was a problem hiding this comment.
With the change being done to local.cfg.skel the security implications is left to the developer, which I like. I'm probably still leaning towards leaning towards leaving the safest option the default (localhost and 127.0.0.1) and let the unsafer option be "opt-in". With that said, I'm not opposed to this change.
added 0.0.0.0 to allowed hosts, for easier testing on other devices than host device