Skip to content

FIX: Easter theme now spans entire body height#565

Open
VinceUB wants to merge 3 commits into
f-klubben:nextfrom
VinceUB:patch-1
Open

FIX: Easter theme now spans entire body height#565
VinceUB wants to merge 3 commits into
f-klubben:nextfrom
VinceUB:patch-1

Conversation

@VinceUB
Copy link
Copy Markdown

@VinceUB VinceUB commented Apr 3, 2025

Fixed an issue where the background image for the easter theme only spans the view, which means that if the page is too long to fit into a single screen, the bottom bit stays unbackgrounded

Fixed an issue where the background image for the easter theme only spans the view, which means that if the page is too long to fit into a single screen, the bottom bit stays unbackgrounded
@VinceUB
Copy link
Copy Markdown
Author

VinceUB commented Apr 3, 2025

Note: I haven't actually tried building this to see if the code works. But I have tried changing the CSS manually with the Firefox devtools

@JakobTopholt
Copy link
Copy Markdown
Contributor

@VinceUB And did it look alright when you did that?

@VinceUB
Copy link
Copy Markdown
Author

VinceUB commented Oct 23, 2025

I think so

Copy link
Copy Markdown
Member

@krestenlaust krestenlaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good change. The old way it was borders on insanity, stretching is much better. Relevant for #555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants