Skip to content

Add fixture migration command#621

Open
krestenlaust wants to merge 17 commits into
nextfrom
feat/improve-migrate-script
Open

Add fixture migration command#621
krestenlaust wants to merge 17 commits into
nextfrom
feat/improve-migrate-script

Conversation

@krestenlaust
Copy link
Copy Markdown
Member

@krestenlaust krestenlaust commented Mar 3, 2026

Adds new command
python manage.py migratefixture --fixture stregsystem/fixtures/testdata.json

Also adds
python manage.py migratefixture --update-targets
Which updates the targets specified in pyproject.toml

And finally adds
migrate-fixtures.sh which does the first command for all fixtures, and the last one to update targets

krestenlaust added a commit that referenced this pull request Mar 3, 2026
Using new script in #621
krestenlaust added a commit that referenced this pull request Mar 3, 2026
Using new changes to script #621
@krestenlaust krestenlaust requested a review from ThomasBow March 3, 2026 19:53
Copy link
Copy Markdown
Contributor

@ThomasBow ThomasBow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, but to summerize maybe just move the all functionallity to a new file and then have it be migrate-all-fixtures and itstead of calling migrate-fixture2 it calls migrate-fixture?

Comment thread migrate-fixture.sh Outdated
Comment thread migrate-fixture.sh Outdated
krestenlaust added a commit that referenced this pull request Mar 13, 2026
@krestenlaust krestenlaust marked this pull request as draft March 14, 2026 00:01
@krestenlaust krestenlaust added this to the Start of Fall 2026 milestone Mar 14, 2026
@krestenlaust
Copy link
Copy Markdown
Member Author

Original shell script:
35277d8

@krestenlaust krestenlaust requested a review from ThomasBow April 3, 2026 21:13
@krestenlaust krestenlaust marked this pull request as ready for review April 3, 2026 21:13
Command has been generated by LLM
@krestenlaust krestenlaust changed the title Improve migrate-fixture script Add fixture migration command Apr 3, 2026
Copy link
Copy Markdown
Contributor

@ThomasBow ThomasBow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Comment thread stregsystem/management/commands/migratefixture.py
@ThomasBow ThomasBow self-requested a review May 19, 2026 21:37
@ThomasBow ThomasBow removed their request for review May 19, 2026 21:39
@ThomasBow
Copy link
Copy Markdown
Contributor

@krestenlaust check changes

@krestenlaust krestenlaust requested a review from ThomasBow May 23, 2026 16:04
@krestenlaust
Copy link
Copy Markdown
Member Author

I haven't tested it, but the code LGTM 👍 @ThomasBow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants