Skip to content

Suppress Warnings in generated classes#145

Open
Wavesonics wants to merge 8 commits into
f2prateek:masterfrom
Wavesonics:master
Open

Suppress Warnings in generated classes#145
Wavesonics wants to merge 8 commits into
f2prateek:masterfrom
Wavesonics:master

Conversation

@Wavesonics

Copy link
Copy Markdown

These were mostly a problem with generics

These were mostly a problem with generics
@stephanenicolas

Copy link
Copy Markdown
Collaborator

@Wavesonics can you make the PR green please ?

@Wavesonics

Copy link
Copy Markdown
Author

Fun fact: You can use travis to fully compile and iterate on your code...

Anyway, looks green now.

@Wavesonics

Copy link
Copy Markdown
Author

Any change to get this PR into the next release?

@f2prateek

Copy link
Copy Markdown
Owner

@Wavesonics looks like the indentation is a bit off in a few places.

@stephanenicolas

Copy link
Copy Markdown
Collaborator

@Wavesonics can you fix the indentation so that we can merge it ?

@stephanenicolas stephanenicolas added this to the 3.0.0 milestone Dec 2, 2017
@dlemures

Copy link
Copy Markdown
Collaborator

The PR is targeting an older version of Dart. @Wavesonics can you reproduce the issue you are trying to solve with the version 3.0.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants