Updated reactive dependencies#136
Open
davrukin wants to merge 8 commits into
Open
Conversation
added 3 commits
June 15, 2020 23:02
JakeWharton
suggested changes
Jun 16, 2020
JakeWharton
left a comment
Contributor
There was a problem hiding this comment.
The package name and Maven groupId need changed or these versions cannot live side-by-side.
Author
|
I’m not sure what you mean since there’s no pom.xml. I’m also not sure why the Travis build is failing, since it’s working with no issues on my end. |
Contributor
|
The groupId is defined in the root |
Author
|
Is there anything else that I may have missed? |
Owner
|
It looks like we may need to update the CI config to accomodate this change: |
Author
|
I’m not sure what changes to make in the yml; are you able to? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated reactive dependencies (RxJava 2 -> 3, RxAndroid 2 -> 3, RxBin…ding 1 -> 4) and removed RxJava2Interop
I have a project in which I’m upgrading all the above listed libraries, and it also uses rx-preferences, which doesn’t have these libraries updated.
Compiled and installed test app, and it works on my Pixel 4.