Skip to content

Updated reactive dependencies#136

Open
davrukin wants to merge 8 commits into
f2prateek:masterfrom
davrukin:rxjava3
Open

Updated reactive dependencies#136
davrukin wants to merge 8 commits into
f2prateek:masterfrom
davrukin:rxjava3

Conversation

@davrukin

Copy link
Copy Markdown

Updated reactive dependencies (RxJava 2 -> 3, RxAndroid 2 -> 3, RxBin…ding 1 -> 4) and removed RxJava2Interop

I have a project in which I’m upgrading all the above listed libraries, and it also uses rx-preferences, which doesn’t have these libraries updated.

Compiled and installed test app, and it works on my Pixel 4.

@JakeWharton JakeWharton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package name and Maven groupId need changed or these versions cannot live side-by-side.

@davrukin

Copy link
Copy Markdown
Author

I’m not sure what you mean since there’s no pom.xml.

I’m also not sure why the Travis build is failing, since it’s working with no issues on my end.

@JakeWharton

Copy link
Copy Markdown
Contributor

The groupId is defined in the root gradle.properties. The package name of all types will need to switch to a "3".

@davrukin

Copy link
Copy Markdown
Author

Is there anything else that I may have missed?

@f2prateek

f2prateek commented Jun 24, 2020

Copy link
Copy Markdown
Owner

It looks like we may need to update the CI config to accomodate this change:

> Task :rx-preferences:mergeExtDexDebugAndroidTest FAILED
AGPBI: {"kind":"error","text":"Static interface methods are only supported starting with Android N (--min-api 24): io.reactivex.rxjava3.disposables.Disposable io.reactivex.rxjava3.disposables.Disposable.disposed()","sources":[{}],"tool":"D8"}

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':rx-preferences:mergeExtDexDebugAndroidTest'.
> Could not resolve all files for configuration ':rx-preferences:debugAndroidTestRuntimeClasspath'.
   > Failed to transform artifact 'rxjava.jar (io.reactivex.rxjava3:rxjava:3.0.4)' to match attributes {artifactType=android-dex, dexing-is-debuggable=true, dexing-min-sdk=9, org.gradle.usage=java-runtime-jars}
      > Execution failed for DexingTransform: /home/travis/.gradle/caches/modules-2/files-2.1/io.reactivex.rxjava3/rxjava/3.0.4/35debb1a7b43bc67e053084f662fa1086b4358aa/rxjava-3.0.4.jar.
         > Error while dexing.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/5.2.1/userguide/command_line_interface.html#sec:command_line_warnings

@davrukin

Copy link
Copy Markdown
Author

I’m not sure what changes to make in the yml; are you able to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants