Add TIME_STEPS to RequestInformation to AlembicReader#2791
Add TIME_STEPS to RequestInformation to AlembicReader#2791LuTheDog wants to merge 11 commits intof3d-app:masterfrom
Conversation
mwestphal
left a comment
There was a problem hiding this comment.
alright, that looks good, lets add a test then :)
|
\ci fast |
|
You are modifying libf3d public API! |
3ed4998 to
10b2cb8
Compare
|
\ci full |
ce904ca to
fd88bb6
Compare
|
Still working on this @LuTheDog ? |
|
I was, but I've been having less and less free time. It's mostly done, but one of the tests fails because of a slowdown, which needs to be debugged. |
|
Can you provide steps to reproduce the issue ? |
|
Just running the ci tests does it, locally or remotely |
Are you talking about this failure ? ? |
|
Exactly |
|
@LuTheDog it doesnt fails because of a slowdown, it fails because, with your changes, the animation is not recovered correctly anymore.
Without your changes: With your changes: So it looks like more work needed im afraid. |
Describe your changes
Issue ticket number and link if any
#2734
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.