Add backdrop.color to libf3d and a f3d option#2989
Open
PedroAbreuMaia wants to merge 27 commits intof3d-app:masterfrom
Open
Add backdrop.color to libf3d and a f3d option#2989PedroAbreuMaia wants to merge 27 commits intof3d-app:masterfrom
PedroAbreuMaia wants to merge 27 commits intof3d-app:masterfrom
Conversation
…ole and application options.
Member
|
thanks, ill review later today. |
mwestphal
reviewed
Mar 31, 2026
mwestphal
reviewed
Mar 31, 2026
mwestphal
reviewed
Mar 31, 2026
mwestphal
reviewed
Mar 31, 2026
mwestphal
reviewed
Mar 31, 2026
mwestphal
reviewed
Mar 31, 2026
mwestphal
reviewed
Mar 31, 2026
mwestphal
reviewed
Mar 31, 2026
applying the suggestion. By default ui.backdrop.color will allways have a value. Co-authored-by: Mathieu Westphal <mwestphal.f3d@protonmail.com>
…etBackdropOpacity.
…D-option' into Add-backdrop.color-libf3d-and-F3D-option
…etBackdropOpacity. Also change BackdropColor and BackdropOpacity attributes.
Member
|
mwestphal
reviewed
Mar 31, 2026
Member
|
\ci fast |
mwestphal
requested changes
Mar 31, 2026
Member
mwestphal
left a comment
mwestphal
left a comment
There was a problem hiding this comment.
one last small change, I've also run CI :)
Co-authored-by: Mathieu Westphal <mwestphal.f3d@protonmail.com>
Author
|
\ci fast |
mwestphal
reviewed
Mar 31, 2026
mwestphal
requested changes
Mar 31, 2026
Co-authored-by: Mathieu Westphal <mwestphal.f3d@protonmail.com>
Member
|
\ci full |
mwestphal
requested changes
Apr 3, 2026
Member
mwestphal
left a comment
mwestphal
left a comment
There was a problem hiding this comment.
this is breaking many tests, it must be changing the default behavior of f3d, which we do not want. Please take a look :)
mwestphal
reviewed
Apr 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2989 +/- ##
==========================================
- Coverage 97.17% 97.06% -0.11%
==========================================
Files 210 208 -2
Lines 16754 16714 -40
==========================================
- Hits 16281 16224 -57
- Misses 473 490 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link if any
#2861
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.