2446 multiple cli options#3155
Conversation
mwestphal
left a comment
mwestphal
left a comment
There was a problem hiding this comment.
Style is not consistent with F3D coding style, but other than that this looks great.
A single design question.
|
\ci fast |
ChristosT
force-pushed
the
2446-multiple-cli-options
branch
from
887d24f to
0c87988
Compare
This allows to store either a string or a vector of strings. The latter becomes useful for options that support multiple values.
fixes warning emited due to [-Werror=unused-variable]
ChristosT
force-pushed
the
2446-multiple-cli-options
branch
from
0c87988 to
a2bbccb
Compare
fixes warning emitted due to [-Werror=shadow]
|
need help moving forward @ChristosT ? |
|
I think I understand the failing edge cases. I just need to make some focus time to resolve them. Thank you ! |
No problem, thanks for the feedback! |
|
need help moving forward @ChristosT ? |
I think it's okay, I just haven't found the time yet... If I cannot complete within a week I can leave it to other members of the community if there is an urgency to complete it. |
No urgency, I'm just checking every single PR every two weeks :) |
2 participants
Describe your changes
This MR adds support for multivalued options. The new infrastructure is applied on
--defineand--reset. The parsing of these two flags use no longer custom code. Instead, the two options are tagged with"valueHelper": "<string_list>"inresources/cli-options.jsonwhich signifies that they could hold one or more values.Issue ticket number and link if any
#2446
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampAI Disclosure
Continuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.