Implement imgui animation progress bar by exbluesbreaker · Pull Request #3223 · f3d-app/f3d

exbluesbreaker · 2026-06-07T21:27:29Z

Describe your changes

Issue ticket number and link if any

Checklist for finalizing the PR

I have performed a self-review of my code
I have added tests for new features and bugfixes
I have added documentation for new features
If it is a modifying the libf3d API, I have updated bindings
If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

AI Disclosure

I did not use AI to generate any of the content of that pull request
I used AI to generate code in that pull request, if yes please disclose which part of the code was generated and with which model.
I used Claude code to figure out imgui components to be used for progress bar visualization and interaction

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

exbluesbreaker · 2026-06-07T21:27:41Z

\ci full

exbluesbreaker · 2026-06-07T21:28:45Z

Implements #3116 . I didn't implement everyting yet - tests and maybe something else (like bindings)

exbluesbreaker · 2026-06-07T21:29:54Z

@mwestphal @Meakk I apologize, but I have vacation next week till Friday without PC access. I will finish missing parts and address review findings after getting back on Jun 12, I hope it is fine.

exbluesbreaker · 2026-06-08T05:05:00Z

Tests seems to fail due to old renders with VTK progress bar, maybe I do not even need to add new dedicated tests - but just fix the old ones.

exbluesbreaker · 2026-06-08T05:05:19Z

Anyway, I will be able to fix it after Friday

mwestphal

looks good on a quick look.

However I wonder if we should have different animation bar mode:

none
default
advanced

@Meakk @Ni-g-3l ?

Meakk · 2026-06-08T06:57:20Z

That looks great indeed!

However I wonder if we should have different animation bar mode

That's probably useful. Maybe we should also adapt the animation bar based on the animation type? key frames with continuous range, fixed time steps (and probably upcoming infinite simulation)

Ni-g-3l · 2026-06-09T08:02:42Z

Here is some screenshot if someone wants to see the change without build the branch :

Ni-g-3l · 2026-06-09T08:09:05Z

looks good on a quick look.

However I wonder if we should have different animation bar mode:
* `none`

* `default`

* `advanced`
@Meakk @Ni-g-3l ?

I'm not sure what you want in each mode however I think it could be good to be able to choose between time navigation or frame (could be done in another PR)

mwestphal · 2026-06-09T08:30:24Z

looks good on a quick look.
However I wonder if we should have different animation bar mode:
* `none`

* `default`

* `advanced`
@Meakk @Ni-g-3l ?
I'm not sure what you want in each mode however I think it could be good to be able to choose between time navigation or frame (could be done in another PR)

none is nothing
default is what is in master
advanced is what you are developing.

Ni-g-3l · 2026-06-09T08:54:45Z

Ah ! I think I would prefer keep the same design for default and advancedand add more information in advanced mode like 'keyframes' 'frame' may be DeltaTime too

exbluesbreaker · 2026-06-12T11:45:23Z

So, I am back. How do we want to proceed with progress bar. We want 3 modes? If so let's be more specific what to do in every mode?

@mwestphal @Meakk @Ni-g-3l

mwestphal · 2026-06-12T12:13:43Z

So, I am back. How do we want to proceed with progress bar. We want 3 modes? If so let's be more specific what to do in every mode?

@mwestphal @Meakk @Ni-g-3l

lets discuss on discord :)

exbluesbreaker · 2026-06-13T10:13:06Z

Advanced:
Screencast from 2026-06-13 12-10-48.webm
Default:
Screencast from 2026-06-13 12-11-11.webm

mwestphal · 2026-06-13T10:22:40Z

Advanced: Screencast from 2026-06-13 12-10-48.webm Default: Screencast from 2026-06-13 12-11-11.webm

Looks great!

mwestphal

LGTM!

codecov · 2026-06-13T22:36:33Z

Codecov Report

❌ Patch coverage is 98.55769% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.03%. Comparing base (7a8cf18) to head (ace6757).
⚠️ Report is 10 commits behind head on master.

Files with missing lines	Patch %	Lines
vtkext/private/module/vtkF3DUIActor.h	25.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3223      +/-   ##
==========================================
+ Coverage   97.01%   97.03%   +0.01%     
==========================================
  Files         212      212              
  Lines       17641    17817     +176     
==========================================
+ Hits        17115    17288     +173     
- Misses        526      529       +3

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mwestphal

Looking good!

exbluesbreaker · 2026-06-26T22:30:13Z

Tried to fix all of the last stuff, there is one open question about enum placement.

exbluesbreaker · 2026-06-26T22:31:13Z

I actually forgot - there were some test failures now, will have a look once this CI is ready. But I was quite surprised that happened - maybe something went wrong at merge/rebase as I remember fixing all the tests before it

mwestphal · 2026-06-27T05:57:17Z

I actually forgot - there were some test failures now, will have a look once this CI is ready. But I was quite surprised that happened - maybe something went wrong at merge/rebase as I remember fixing all the tests before it

let me know if you need any help :)

mwestphal

lgtm, lets fix CI :)

exbluesbreaker · 2026-06-27T20:09:13Z

I updated few other cases of "default" progress bar with scalar bar, new change of the way bar is rendered affected default mode as well, but in a good way I believe.

exbluesbreaker · 2026-06-27T23:10:53Z

Looks good from my side, I seemed to fix evertying @mwestphal @Meakk @snoyer @Ni-g-3l

mwestphal

Awesome work! One question about the behavior of juimp_to_time.

Sorrry, I should have caught it earlier.

Draw an interactive progress bar at the bottom of the view during playback. Click or drag it to seek to a point in time. --animation-progress becomes a mode string instead of a boolean flag: none, default (the bar alone), or advanced (adds time range, animation name, current time, keyframe markers and a hover tooltip). A bare --animation-progress implies default. Seeking is backed by two new commands, jump_to_time and jump_to_time_relative (time in seconds), mirroring the jump_to_frame / jump_to_frame_relative pair. They are wired through the ImGui actor, renderer and animation manager so the bar tracks playback. The scalar bar is offset by the progress bar height so the two no longer overlap.

Meakk

Incredible work! Well done @exbluesbreaker!

exbluesbreaker requested a review from a team as a code owner June 7, 2026 21:27

mwestphal added the ci:full label Jun 7, 2026

exbluesbreaker force-pushed the animation_imgui_progress_bar branch 4 times, most recently from ef7c2ec to 6ba4153 Compare June 8, 2026 04:48

mwestphal reviewed Jun 8, 2026

View reviewed changes

exbluesbreaker force-pushed the animation_imgui_progress_bar branch from 6ba4153 to b5ce522 Compare June 13, 2026 10:11

mwestphal reviewed Jun 13, 2026

View reviewed changes

exbluesbreaker force-pushed the animation_imgui_progress_bar branch 3 times, most recently from 0c6d349 to 7f68735 Compare June 13, 2026 21:41

exbluesbreaker force-pushed the animation_imgui_progress_bar branch 3 times, most recently from 983e4cf to aeb8fde Compare June 16, 2026 21:26

mwestphal reviewed Jun 26, 2026

View reviewed changes

Comment thread application/testing/tests.features.cmake

mwestphal requested changes Jun 26, 2026

View reviewed changes

Comment thread doc/user/03-OPTIONS.md Outdated

Comment thread vtkext/private/module/vtkF3DRenderer.cxx

Comment thread vtkext/private/module/vtkF3DUIActor.h

exbluesbreaker force-pushed the animation_imgui_progress_bar branch from 6e18124 to 17579ae Compare June 26, 2026 22:28

exbluesbreaker requested a review from mwestphal June 26, 2026 22:29

mwestphal reviewed Jun 27, 2026

View reviewed changes

Comment thread doc/user/07-COMMANDS.md Outdated

mwestphal reviewed Jun 27, 2026

View reviewed changes

exbluesbreaker force-pushed the animation_imgui_progress_bar branch 4 times, most recently from e582403 to f58eae8 Compare June 27, 2026 19:43

exbluesbreaker force-pushed the animation_imgui_progress_bar branch from f58eae8 to fa8479e Compare June 27, 2026 22:00

exbluesbreaker requested a review from mwestphal June 27, 2026 23:10

mwestphal reviewed Jun 28, 2026

View reviewed changes

Comment thread doc/user/05-ANIMATIONS.md Outdated

mwestphal reviewed Jun 28, 2026

View reviewed changes

Comment thread library/src/animationManager.cxx Outdated

mwestphal reviewed Jun 28, 2026

View reviewed changes

Comment thread vtkext/private/module/vtkF3DImguiActor.cxx Outdated

mwestphal requested changes Jun 28, 2026

View reviewed changes

exbluesbreaker requested a review from mwestphal June 28, 2026 11:12

mwestphal approved these changes Jun 28, 2026

View reviewed changes

mwestphal requested a review from a team June 28, 2026 11:28

exbluesbreaker force-pushed the animation_imgui_progress_bar branch from fe75711 to ace6757 Compare June 28, 2026 11:29

Ni-g-3l approved these changes Jun 29, 2026

View reviewed changes

Meakk approved these changes Jun 29, 2026

View reviewed changes

Meakk merged commit 0fb136e into f3d-app:master Jun 29, 2026
55 checks passed

mwestphal mentioned this pull request Jun 29, 2026

Improve timeline UI #3116

Closed

Uh oh!

Uh oh!

Conversation

exbluesbreaker commented Jun 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes

Issue ticket number and link if any

Checklist for finalizing the PR

AI Disclosure

Continuous integration

Uh oh!

exbluesbreaker commented Jun 7, 2026

Uh oh!

exbluesbreaker commented Jun 7, 2026

Uh oh!

exbluesbreaker commented Jun 7, 2026

Uh oh!

exbluesbreaker commented Jun 8, 2026

Uh oh!

exbluesbreaker commented Jun 8, 2026

Uh oh!

mwestphal left a comment

Choose a reason for hiding this comment

Uh oh!

Meakk commented Jun 8, 2026

Uh oh!

Ni-g-3l commented Jun 9, 2026

Uh oh!

Ni-g-3l commented Jun 9, 2026

Uh oh!

mwestphal commented Jun 9, 2026

Uh oh!

Ni-g-3l commented Jun 9, 2026

Uh oh!

exbluesbreaker commented Jun 12, 2026

Uh oh!

mwestphal commented Jun 12, 2026

Uh oh!

exbluesbreaker commented Jun 13, 2026

Uh oh!

mwestphal commented Jun 13, 2026

Uh oh!

mwestphal left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

mwestphal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

exbluesbreaker commented Jun 26, 2026

Uh oh!

exbluesbreaker commented Jun 26, 2026

Uh oh!

mwestphal commented Jun 27, 2026

Uh oh!

Uh oh!

mwestphal left a comment

Choose a reason for hiding this comment

Uh oh!

exbluesbreaker commented Jun 27, 2026

Uh oh!

exbluesbreaker commented Jun 27, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mwestphal left a comment

Choose a reason for hiding this comment

Uh oh!

Meakk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

exbluesbreaker commented Jun 7, 2026 •

edited

Loading

codecov Bot commented Jun 13, 2026 •

edited

Loading