Initial XR support#3245
Draft
AoGao-Kedoka wants to merge 8 commits into
Draft
Conversation
|
You are modifying libf3d public API! |
Meakk
reviewed
Jun 17, 2026
| overlayP->SetDelegatePass(renderingPass); | ||
|
|
||
| this->SetPass(overlayP); | ||
| this->SetPass(overlayP); |
Member
There was a problem hiding this comment.
Don't you still need to call this->SetPass(renderingPass); when XR is enabled in order to have all other features (AA, AO, blending...)?
Contributor
Author
There was a problem hiding this comment.
yeah, that's also the next step i need to validate. There's still graphics bugs with vtkF3DRenderpass that i need to fix.
Will keep this one unresolved until it's being fixed.
AoGao-Kedoka
force-pushed
the
xr
branch
3 times, most recently
from
992389b to
9796670
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adding XR support in rendering. Interacting is handled in another PR.
scale and location of the object in the scene still needs to be handled.
Issue ticket number and link if any
#749
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampAI Disclosure
GPT5.5 for Creating the bounding box and align objects to the bounding box. Reviewed and tested carefully.
Continuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.