Handle exceptions in C bindings#3246
Conversation
|
\ci fast |
|
❌ Invalid CI command "fast" |
strange |
|
Thanks for the PR, feel free to flag as readcy for review when it is! :) |
mwestphal
left a comment
There was a problem hiding this comment.
Are you sure you checked all calls to the libf3d ? I'd have expected more exceptions.
I believe so, some bindings were already handling exceptions so I didn't have to do anything there. But here's the modules I checked:
|
mwestphal
left a comment
There was a problem hiding this comment.
options.h not properly try/catch
|
You are modifying libf3d public API! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3246 +/- ##
=======================================
Coverage 97.06% 97.06%
=======================================
Files 213 212 -1
Lines 17656 17570 -86
=======================================
- Hits 17137 17054 -83
+ Misses 519 516 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks a lot for your contribution (and persistence!) @bo-dani |
Describe your changes
As explained in the issue, some C bindings are not handling exceptions explicitly thrown by the library. This PR addresses this. I'm only catching specific exceptions based on this comment.
Issue ticket number and link if any
Implements #2763.
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampAI Disclosure
Continuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.