Skip to content

Update VTK#3247

Merged
mwestphal merged 5 commits into
f3d-app:masterfrom
mwestphal:update_vtk
Jun 26, 2026
Merged

Update VTK#3247
mwestphal merged 5 commits into
f3d-app:masterfrom
mwestphal:update_vtk

Conversation

@mwestphal

@mwestphal mwestphal commented Jun 19, 2026

Copy link
Copy Markdown
Member

Describe your changes

Issue ticket number and link if any

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

AI Disclosure

  • I did not use AI to generate any of the content of that pull request
  • I used AI to generate code in that pull request, if yes please disclose which part of the code was generated and with which model.
  • ...

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

You are modifying versions.json, please update the docker timestamp as well, then run the cache preheating workflow (maintainers only). This will generate new docker images and caches needed for CI.

@mwestphal mwestphal marked this pull request as ready for review June 20, 2026 08:42
@mwestphal mwestphal requested a review from a team as a code owner June 20, 2026 08:42
@mwestphal mwestphal requested review from Meakk and removed request for a team June 20, 2026 08:53
@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.01%. Comparing base (7a8cf18) to head (4c4e72b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3247   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files         212      212           
  Lines       17641    17641           
=======================================
  Hits        17115    17115           
  Misses        526      526           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Meakk Meakk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it's not ready for review?

Comment thread library/src/interactor_impl.cxx Outdated
@mwestphal

Copy link
Copy Markdown
Member Author

I suppose it's not ready for review?

yeah sorry, this is waiting on the egl warning thing

@mwestphal mwestphal changed the title Update VTK to 7b7d6f27a3c6fac37a7ea8f258d398fce6b6ca83 Update VTK Jun 25, 2026
Comment thread testing/baselines/TestAxesGridEnable.png
@Meakk

Meakk commented Jun 25, 2026

Copy link
Copy Markdown
Member

You will have to increase the threshold for TestAxesGridEnableSSAA

Comment thread testing/baselines/TestThumbnailConfigFileWebP.png
@mwestphal mwestphal merged commit 4dcbd5d into f3d-app:master Jun 26, 2026
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants