Skip to content

Add support for saving/loading statefiles#3249

Open
noclone wants to merge 36 commits into
f3d-app:masterfrom
noclone:statefiles
Open

Add support for saving/loading statefiles#3249
noclone wants to merge 36 commits into
f3d-app:masterfrom
noclone:statefiles

Conversation

@noclone

@noclone noclone commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Describe your changes

  • Add statefile support: save/restore the engine state as a JSON file

Issue ticket number and link if any

#1777

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

AI Disclosure

  • I did not use AI to generate any of the content of that pull request
  • I used AI to generate code in that pull request, if yes please disclose which part of the code was generated and with which model.
  • I used Opus 4.8 to generate the bindings. I reviewed each line and modified when necessary.

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@noclone noclone requested a review from a team as a code owner June 21, 2026 09:00
@github-actions

Copy link
Copy Markdown

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: c, python, java, webassembly.

@noclone

noclone commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

\ci fast

Comment thread application/F3DStarter.h Outdated

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one design choice to discuss

@noclone noclone requested a review from mwestphal June 21, 2026 13:42
Comment thread library/src/engine.cxx Outdated
Comment thread library/src/engine.cxx Outdated
Comment thread library/src/engine.cxx Outdated
Comment thread library/src/engine.cxx Outdated
Comment thread library/src/scene_impl.cxx Outdated
Comment thread library/src/engine.cxx Outdated
Comment thread library/src/engine.cxx Outdated

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

questions and remarks

@noclone noclone requested a review from mwestphal June 21, 2026 18:35
Comment thread doc/user/03-OPTIONS.md
Comment thread library/src/engine.cxx
Comment thread doc/user/07-COMMANDS.md Outdated

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a question about the cli options behavior

@mwestphal mwestphal requested review from Meakk and mwestphal June 22, 2026 07:32
Comment thread resources/cli-options.json Outdated
Comment thread application/F3DStarter.cxx
Comment thread application/F3DStarter.cxx
@noclone noclone requested a review from mwestphal June 22, 2026 21:33
Comment thread application/F3DStarter.cxx Outdated

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One design question, then better for @Meakk to take a last design look before we get into deep review

@noclone noclone requested a review from mwestphal June 23, 2026 10:14
Comment thread library/public/engine.h Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants