Remove bool flag for jump_to commands#3250
Conversation
|
\ci full |
|
@mwestphal Rework for bool flag in jump_to commands |
|
how about |
Honestly, I do not like it, having |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3250 +/- ##
==========================================
+ Coverage 97.06% 97.07% +0.01%
==========================================
Files 212 212
Lines 17570 17640 +70
==========================================
+ Hits 17054 17124 +70
Misses 516 516 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
no strong opinion. @Meakk ? |
thinking back on it, i prefer it being explicit |
d5dcbd1 to
603c851
Compare
|
@mwestphal Added MIGRATION.md update |
|
I prefer |
|
oops, forgot missing test failure, though not sure what is it about |
Flaky test, you can ignore, @Meakk is looking at it. |
603c851 to
b9bd351
Compare
|
I implemented suggestion |
|
Thanks for the contribution @exbluesbreaker ! |
Describe your changes
Issue ticket number and link if any
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampAI Disclosure
Continuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.