feat: add default_sync and is_async feature gate#26
Open
XLPhere wants to merge 1 commit into
Open
Conversation
XLPhere
force-pushed
the
default_sync
branch
2 times, most recently
from
January 19, 2025 15:21
ba39034 to
4de3359
Compare
Author
|
Oh i just noticed this is a duplicate to #12 - my bad @qiuchengxuan! i saw it right after creating this PR 😅 |
Purpose of these features is to enable depdendants to provide a feature to enable async support instead of a feature to disable it. Creates (which would want to be sync by default) could then: * Always enable the `default_sync` feature. * Enable async support with the `is_async` feature when needed.
|
I'd love to see this merged! I'm currently using this pull in my own fork but merging this would be really helpful. @fMeow? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of these features is to enable depdendants to provide a feature to enable async support instead of a feature to disable it. Creates (which would want to be sync by default) could then:
default_syncfeature.is_asyncfeature when needed.