Unpin requests; pin urllib3 to match botocore 1.32.6#229
Closed
alasdairnicol wants to merge 1 commit intofabfuel:developfrom
Closed
Unpin requests; pin urllib3 to match botocore 1.32.6#229alasdairnicol wants to merge 1 commit intofabfuel:developfrom
alasdairnicol wants to merge 1 commit intofabfuel:developfrom
Conversation
Author
|
This is no longer an issue after 8b62e09 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be good to remove the pin
requests<2.30.0so that we can install the latest version of requests.I assume the pin was added because botocore was not compatible with urllib3 2.0+ for a while. Therefore I suggest that
we pin urllib3 instead of requests.
I've copied the urllib3 requirements from botocore 1.32.6, which is the minimum version that ecs-deploy supports. Another option would be to pin
urllib3<1.27rather than having different pins for different python versions.Eventually, we can remove the pin when ecs-deploy drops support for Python 3.10.
I've tested this on Python 3.9, which installs:
and Python 3.12, which installs:
However, I am not sure what the original error was before the
requests<2.30.0pin was added, so I can't be certain that this change works.