Skip to content

Commit 2c4bc0a

Browse files
committed
Revert "feat(timeline): add endpoint to retrieve timeline of a household (#161)"
This reverts commit 3a0bbf7.
1 parent 3a0bbf7 commit 2c4bc0a

2 files changed

Lines changed: 5 additions & 11 deletions

File tree

surehub_api/routers/households.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
from surehub_api.entities import official
77
from surehub_api.entities.openapi import Tags
8-
from surehub_api.services import households, reports, timeline
8+
from surehub_api.services import households, reports
99

1010
router = APIRouter(
1111
prefix="/households",
@@ -70,9 +70,3 @@ async def get_devices_of_household(household_id: int) -> List[official.Device]:
7070
response_model_exclude_none=True)
7171
async def get_device_of_household(household_id: int, device_id: int) -> official.Device:
7272
return households.get_device_of_household(household_id, device_id)
73-
74-
75-
@router.get("/{household_id}/timeline",
76-
response_model_exclude_none=True)
77-
async def get_timeline_of_household(household_id: int) -> list[official.Timeline]:
78-
return timeline.get_timeline_of_household(household_id)

surehub_api/services/timeline.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
import math
2+
from typing import Any
23

34
from fastapi import HTTPException
45

56
from surehub_api.config import settings
6-
from surehub_api.entities import official
77
from surehub_api.services import api
88
from surehub_api.utils import response_handler
99

1010

11-
def get_timeline_of_household(household_id: int) -> list[official.Timeline]:
11+
def get_timeline_of_household(household_id: int) -> list[dict[str, Any]]:
1212
uri = f"{settings.endpoint}/api/timeline/household/{household_id}"
1313

14-
result: list[official.Timeline] = []
14+
result = []
1515
fetch_size = 100
1616

1717
response = api.get(uri)
@@ -27,6 +27,6 @@ def get_timeline_of_household(household_id: int) -> list[official.Timeline]:
2727
for i in range(1, request_count + 1):
2828
payload = {'page_size': fetch_size, 'page': i}
2929
response2 = api.get(uri, params=payload)
30-
result += response_handler.parse(response2, model=official.Timeline)
30+
result += response_handler.parse(response2)
3131

3232
return result

0 commit comments

Comments
 (0)