Fix TypeError when a keypath sets a string subkey through a list value#591
Open
santhreal wants to merge 1 commit into
Open
Fix TypeError when a keypath sets a string subkey through a list value#591santhreal wants to merge 1 commit into
santhreal wants to merge 1 commit into
Conversation
Setting a keypath whose parent value is a list but whose next key is a
non-integer string (e.g. b['a.x'] = 1 with a=[1, 2]) raised a raw
TypeError: list indices must be integers or slices, not str, while the
same assignment over a scalar/None value overrides it with a new dict.
A list cannot hold a string key, so treat it like a scalar and override
it, keeping the behavior consistent (b['a.x'] -> {'a': {'x': 1}}). Valid
integer indexes still address the list unchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #591 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 64 64
Lines 2418 2419 +1
=======================================
+ Hits 2379 2380 +1
Misses 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting a keypath whose parent value is a list but whose next key is a non-integer string raises a raw
TypeError: list indices must be integers or slices, not str, even though the same assignment over a scalar/Nonevalue overrides it with a new dict, and reading the same keypath raises the library's ownKeyError.A list cannot hold a string key, so it is now overridden the same way a scalar is, keeping keypath assignment consistent. Valid integer indexes still address the list unchanged. The fix is at the single navigation choke point, so
subset/move/unflattenare covered too.