Skip to content

Fix unit conversion bug#30

Closed
danimateos wants to merge 0 commit into
fablabbcn:masterfrom
danimateos:master
Closed

Fix unit conversion bug#30
danimateos wants to merge 0 commit into
fablabbcn:masterfrom
danimateos:master

Conversation

@danimateos

Copy link
Copy Markdown
Collaborator

No description provided.

@danimateos danimateos closed this Dec 4, 2025
@danimateos danimateos reopened this Dec 4, 2025
@danimateos danimateos self-assigned this Dec 4, 2025
@danimateos

Copy link
Copy Markdown
Collaborator Author

Failing test fails with

python3.11/site-packages/scdata/device/device.py:165: PydanticDeprecatedSince211: Accessing the 'model_fields' attribute on the instance is deprecated. Instead, you should access this attribute from the model class. Deprecated in Pydantic V2.11 to be removed in V3.0.

I don't know how to change that.

@oscgonfer

oscgonfer commented Dec 4, 2025

Copy link
Copy Markdown
Collaborator

@danimateos I think we touched similar things at the same time, sorry - you'd need to rebase and check again with my latest release (1.3.2).

The tests didn't fail because of pydantic, they just timed-out. I re-run them and they are all good. We should limit pydantic to pydantic<3.0

@danimateos danimateos closed this Dec 5, 2025
danimateos added a commit that referenced this pull request Dec 5, 2025
Fix unit conversion bug (rehash of #30)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants