Skip to content

Commit c91f38e

Browse files
github-actions[bot]Copilotdbrattliclaude
authored
chore(build): fix clean/clean-all inconsistency and remove redundant build step (#275)
* chore(build): fix clean/clean-all inconsistency and redundant build step - clean no longer removes src/test obj/bin directories; the comment already said it should preserve these (for faster incremental builds) - clean-all now correctly adds the obj/bin removal on top of clean, making it non-redundant (previously clean and clean-all did the same thing) - remove redundant `dotnet build test` in test recipe; dotnet run already performs an implicit build before executing Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore(build): drop redundant dotnet build from test-native `dotnet run --project` performs an implicit build, matching the rationale already applied to the `test` recipe in this PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Dag Brattli <dag@brattli.net> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 7dd78ba commit c91f38e

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

justfile

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,20 +17,18 @@ fable := if dev == "true" { "dotnet run --project " + fable_repo / "src/Fable.Cl
1717
default:
1818
@just --list
1919

20-
# Clean Fable build output (preserves dotnet obj/bin directories)
20+
# Clean Fable build output (preserves dotnet obj/bin restore cache for faster incremental builds)
2121
clean:
2222
rm -rf {{build_path}}
23-
rm -rf {{src_path}}/obj {{src_path}}/bin
24-
rm -rf {{test_path}}/obj {{test_path}}/bin
2523
rm -rf examples/*/build examples/*/obj examples/*/bin
2624
rm -rf examples/*/src/obj examples/*/src/bin
2725
rm -rf examples/*/.fable examples/*/src/.fable
2826
rm -rf .fable
2927

30-
# Deep clean - removes everything including dotnet obj/bin directories
28+
# Deep clean - removes everything including dotnet obj/bin directories (forces full NuGet restore)
3129
clean-all: clean
32-
rm -rf {{src_path}}/obj {{test_path}}/obj
33-
rm -rf {{src_path}}/bin {{test_path}}/bin
30+
rm -rf {{src_path}}/obj {{src_path}}/bin
31+
rm -rf {{test_path}}/obj {{test_path}}/bin
3432

3533
# Build F# source to Python using Fable
3634
build: clean
@@ -44,7 +42,6 @@ run: clean
4442

4543
# Run all tests (native .NET and Python)
4644
test: build
47-
dotnet build {{test_path}}
4845
@echo "Running native .NET tests..."
4946
dotnet run --project {{test_path}}
5047
@echo "Compiling and running Python tests..."
@@ -53,7 +50,6 @@ test: build
5350

5451
# Run only native .NET tests
5552
test-native:
56-
dotnet build {{test_path}}
5753
dotnet run --project {{test_path}}
5854

5955
# Run only Python tests (requires build first)

0 commit comments

Comments
 (0)