Skip to content

Commit 146540a

Browse files
alfonsogarciacaroalfonsogarciacaro
committed
Remove commented JSON tests
1 parent bb39da2 commit 146540a

12 files changed

Lines changed: 8 additions & 931 deletions

‎tests/Main/ConvertTests.fs‎

Lines changed: 0 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -1152,61 +1152,4 @@ let tests =
11521152
System.Text.Encoding.UTF8.GetString(bytes, 6, 6)
11531153
|> equal "\u03B2\uD8FF\uDCFF"
11541154

1155-
1156-
// testCase "int64 can be JSON serialized forth and back" <| fun () ->
1157-
// let val1 = 5348937298839933899L
1158-
// #if FABLE_COMPILER
1159-
// let json = Fable.Core.JsInterop.toJson val1
1160-
// let val2 = Fable.Core.JsInterop.ofJson<int64> json
1161-
// equal true (box val2 :? int64) // Type is kept
1162-
// equal val1 val2
1163-
// equal val2 5348937298839933899L
1164-
// let val2 = Fable.Core.JsInterop.ofJsonAsType json (val1.GetType())
1165-
// equal true (val2 :? int64) // Type is kept
1166-
// let val2 = val2 :?> int64
1167-
// #else
1168-
// let json = Newtonsoft.Json.JsonConvert.SerializeObject val1
1169-
// let val2 = Newtonsoft.Json.JsonConvert.DeserializeObject<int64> json
1170-
// #endif
1171-
// // printfn "JSON: %s" json
1172-
// equal val1 val2
1173-
// equal val2 5348937298839933899L
1174-
1175-
// testCase "uint64 can be JSON serialized forth and back" <| fun () ->
1176-
// let val1 = 9348937298839933899UL
1177-
// #if FABLE_COMPILER
1178-
// let json = Fable.Core.JsInterop.toJson val1
1179-
// let val2 = Fable.Core.JsInterop.ofJson<uint64> json
1180-
// equal true (box val2 :? uint64) // Type is kept
1181-
// equal val1 val2
1182-
// equal val2 9348937298839933899UL
1183-
// let val2 = Fable.Core.JsInterop.ofJsonAsType json (val1.GetType())
1184-
// equal true (val2 :? uint64) // Type is kept
1185-
// let val2 = val2 :?> uint64
1186-
// #else
1187-
// let json = Newtonsoft.Json.JsonConvert.SerializeObject val1
1188-
// let val2 = Newtonsoft.Json.JsonConvert.DeserializeObject<uint64> json
1189-
// #endif
1190-
// // printfn "JSON: %s" json
1191-
// equal val1 val2
1192-
// equal val2 9348937298839933899UL
1193-
1194-
// testCase "BigInts can be JSON serialized forth and back" <| fun () ->
1195-
// let val1 = 59823749821707124891298739821798327321028091380980I
1196-
// #if FABLE_COMPILER
1197-
// let json = Fable.Core.JsInterop.toJson val1
1198-
// let val2 = Fable.Core.JsInterop.ofJson<bigint> json
1199-
// equal true (box val2 :? bigint) // Type is kept
1200-
// equal val1 val2
1201-
// equal val2 59823749821707124891298739821798327321028091380980I
1202-
// let val2 = Fable.Core.JsInterop.ofJsonAsType json (val1.GetType())
1203-
// equal true (val2 :? bigint) // Type is kept
1204-
// let val2 = val2 :?> bigint
1205-
// #else
1206-
// let json = Newtonsoft.Json.JsonConvert.SerializeObject val1
1207-
// let val2 = Newtonsoft.Json.JsonConvert.DeserializeObject<bigint> json
1208-
// #endif
1209-
// // printfn "JSON: %s" json
1210-
// equal val1 val2
1211-
// equal val2 59823749821707124891298739821798327321028091380980I
12121155
]

‎tests/Main/DateTimeOffsetTests.fs‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,6 @@ let tests =
3636
System.Text.RegularExpressions.Regex.Replace(str, "0{3,}", "000")
3737
|> equal "2014-09-11T16:37:02.000+00:00"
3838

39-
// testCase "DateTimeOffset can be JSON serialized forth and back" <| fun () ->
40-
// let dof = DateTimeOffset(2016, 8, 4, 17, 30, 0, TimeSpan.FromHours(3.))
41-
// #if FABLE_COMPILER
42-
// let json = Fable.Core.JsInterop.toJson dof
43-
// let dof = Fable.Core.JsInterop.ofJson<DateTimeOffset> json
44-
// #else
45-
// let json = Newtonsoft.Json.JsonConvert.SerializeObject dof
46-
// let dof = Newtonsoft.Json.JsonConvert.DeserializeObject<DateTimeOffset> json
47-
// #endif
48-
// dof.Offset |> equal (TimeSpan.FromHours(3.))
49-
// dof.ToString("HH:mm") |> equal "17:30"
50-
5139
testCase "DateTimeOffset from Year 1 to 99 works" <| fun () ->
5240
let date = DateTimeOffset(1, 1, 1, 0, 0, 0, TimeSpan.Zero)
5341
date.Year |> equal 1

‎tests/Main/DateTimeTests.fs‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -44,18 +44,6 @@ let tests =
4444
// DateTime(2014, 9, 11, 16, 37, 2, DateTimeKind.Local).ToString("O")
4545
// |> equal "2014-09-11T16:37:02.000+02:00" // Here the time zone is Europte/Paris (GMT+2)
4646

47-
// testCase "DateTime can be JSON serialized forth and back" <| fun () ->
48-
// let utc = DateTime(2016, 8, 4, 17, 30, 0, DateTimeKind.Utc)
49-
// #if FABLE_COMPILER
50-
// let json = Fable.Core.JsInterop.toJson utc
51-
// let utc = Fable.Core.JsInterop.ofJson<DateTime> json
52-
// #else
53-
// let json = Newtonsoft.Json.JsonConvert.SerializeObject utc
54-
// let utc = Newtonsoft.Json.JsonConvert.DeserializeObject<DateTime> json
55-
// #endif
56-
// utc.Kind = DateTimeKind.Utc |> equal true
57-
// utc.ToString("HH:mm") |> equal "17:30"
58-
5947
testCase "DateTime from Year 1 to 99 works" <| fun () ->
6048
let date = DateTime(1, 1, 1)
6149
date.Year |> equal 1

‎tests/Main/DictionaryTests.fs‎

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -242,35 +242,4 @@ let tests =
242242
dic.Values.Count
243243
|> equal 2
244244

245-
// testCase "Dictionaries can be JSON serialized forth and back" <| fun () ->
246-
// let x = Dictionary<_,_>()
247-
// x.Add("a", { i=1; s="1" })
248-
// x.Add("b", { i=2; s="2" })
249-
// #if FABLE_COMPILER
250-
// let json = Fable.Core.JsInterop.toJson x
251-
// let x2 = Fable.Core.JsInterop.ofJson<Dictionary<string, R>> json
252-
// (0, x2) ||> Seq.fold (fun acc kv -> acc + kv.Value.i)
253-
// |> equal 3
254-
// let json = Fable.Core.JsInterop.toJsonWithTypeInfo x
255-
// let x2 = Fable.Core.JsInterop.ofJsonWithTypeInfo<Dictionary<string, R>> json
256-
// #else
257-
// let json = Newtonsoft.Json.JsonConvert.SerializeObject x
258-
// let x2 = Newtonsoft.Json.JsonConvert.DeserializeObject<Dictionary<string, R>> json
259-
// #endif
260-
// (0, x2) ||> Seq.fold (fun acc kv -> acc + kv.Value.i)
261-
// |> equal 3
262-
263-
// testCase "Dictionaries serialized with Json.NET can be deserialized" <| fun () ->
264-
// // let x = Dictionary<_,_>()
265-
// // x.Add("a", { i=1; s="1" })
266-
// // x.Add("b", { i=2; s="2" })
267-
// // let json = JsonConvert.SerializeObject(x, JsonSerializerSettings(TypeNameHandling=TypeNameHandling.All))
268-
// let json = """{"$type":"System.Collections.Generic.Dictionary`2[[System.String, mscorlib],[Fable.Tests.Maps+R, Fable.Tests]], FSharp.Core","a":{"$type":"Fable.Tests.Maps+R, Fable.Tests","i":1,"s":"1"},"b":{"$type":"Fable.Tests.Maps+R, Fable.Tests","i":2,"s":"2"}}"""
269-
// #if FABLE_COMPILER
270-
// let x2 = Fable.Core.JsInterop.ofJsonWithTypeInfo<Dictionary<string, R>> json
271-
// #else
272-
// let x2 = Newtonsoft.Json.JsonConvert.DeserializeObject<Dictionary<string, R>> json
273-
// #endif
274-
// (0, x2) ||> Seq.fold (fun acc kv -> acc + kv.Value.i)
275-
// |> equal 3
276245
]

‎tests/Main/Fable.Tests.fsproj‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
<Compile Include="HashSetTests.fs" />
4242
<Compile Include="ImportTests.fs" />
4343
<Compile Include="JsInteropTests.fs" />
44-
<!-- <Compile Include="JsonTests.fs" /> -->
4544
<Compile Include="ListTests.fs" />
4645
<Compile Include="MapTests.fs" />
4746
<Compile Include="MiscTestsHelper.fs" />

‎tests/Main/HashSetTests.fs‎

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -206,34 +206,4 @@ let tests =
206206
apa.Contains ({ i = 5; s = "foo"}) |> equal true
207207
apa.Contains ({ i = 5; s = "fo"}) |> equal false
208208

209-
// testCase "HashSet can be JSON serialized forth and back" <| fun () ->
210-
// let x = HashSet<_>()
211-
// x.Add(1) |> ignore
212-
// x.Add(2) |> ignore
213-
// #if FABLE_COMPILER
214-
// let json = Fable.Core.JsInterop.toJson x
215-
// let x2 = Fable.Core.JsInterop.ofJson<HashSet<int>> json
216-
// x2.IsSubsetOf x |> equal true
217-
// (0, x2) ||> Seq.fold (fun acc v -> acc + v) |> equal 3
218-
// let json = Fable.Core.JsInterop.toJsonWithTypeInfo x
219-
// let x2 = Fable.Core.JsInterop.ofJsonWithTypeInfo<HashSet<int>> json
220-
// #else
221-
// let json = Newtonsoft.Json.JsonConvert.SerializeObject x
222-
// let x2 = Newtonsoft.Json.JsonConvert.DeserializeObject<HashSet<int>> json
223-
// #endif
224-
// x2.IsSubsetOf x |> equal true
225-
// (0, x2) ||> Seq.fold (fun acc v -> acc + v) |> equal 3
226-
227-
// testCase "HashSet serialized with Json.NET can be deserialized" <| fun () ->
228-
// // let x = HashSet<_>()
229-
// // x.Add({ i=1; s="1" }) |> ignore
230-
// // x.Add({ i=2; s="2" }) |> ignore
231-
// // let json = JsonConvert.SerializeObject(x, JsonSerializerSettings(TypeNameHandling=TypeNameHandling.All))
232-
// let json = """{"$type":"System.Collections.Generic.HashSet`1[[Fable.Tests.HashSets+R, Fable.Tests]], FSharp.Core","$values":[{"$type":"Fable.Tests.HashSets+R, Fable.Tests","i":1,"s":"1"},{"$type":"Fable.Tests.HashSets+R, Fable.Tests","i":2,"s":"2"}]}"""
233-
// #if FABLE_COMPILER
234-
// let x2 = Fable.Core.JsInterop.ofJsonWithTypeInfo<HashSet<R>> json
235-
// #else
236-
// let x2 = Newtonsoft.Json.JsonConvert.DeserializeObject<HashSet<R>> json
237-
// #endif
238-
// (0, x2) ||> Seq.fold (fun acc v -> acc + v.i) |> equal 3
239209
]

0 commit comments

Comments
 (0)