Skip to content

[Python] More typing fixes#4334

Merged
dbrattli merged 2 commits into
mainfrom
python-typing-fixes-18
Jan 11, 2026
Merged

[Python] More typing fixes#4334
dbrattli merged 2 commits into
mainfrom
python-typing-fixes-18

Conversation

@dbrattli

@dbrattli dbrattli commented Jan 11, 2026

Copy link
Copy Markdown
Collaborator

This PR continues the work on improving Python type annotations in the Fable compiler. It addresses several edge cases related to:

  • Option type erasure for CurriedApply expressions (previously only handled Call)
  • Callable type annotations for functions that take unit as the only argument
  • Generic parameter handling in Option type annotations
  • Union case field annotations for lambda/function types
  • ResourceManager-wrapped return strategies (e.g., inside with blocks)

@github-actions

github-actions Bot commented Jan 11, 2026

Copy link
Copy Markdown
Contributor

Python Type Checking Results (Pyright)

Metric Value
Total errors 13
Files with errors 2
Excluded files 3
New errors ✅ No
Excluded files with errors (3 files)

These files have known type errors and are excluded from CI. Remove from pyrightconfig.ci.json as errors are fixed.

File Errors Status
temp/tests/Python/test_applicative.py 12 Excluded
temp/tests/Python/fable_modules/thoth_json_python/encode.py 1 Excluded

@dbrattli dbrattli merged commit 3afed51 into main Jan 11, 2026
23 checks passed
@dbrattli dbrattli deleted the python-typing-fixes-18 branch January 11, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant