Skip to content

[Repo Assist] [All] Fix unnecessary allocations in AST visitor for Import expressions #4455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbrattli merged 2 commits into from
Apr 3, 2026
Merged

[Repo Assist] [All] Fix unnecessary allocations in AST visitor for Import expressions #4455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d31128
Fix unnecessary allocations in AST visitor for Import expressions
github-actions[bot] Mar 28, 2026
99d7103
Merge main into PR branch, resolve changelog conflicts
dbrattli Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Fable.Cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

* [All] Fix unnecessary object allocations during AST traversal when visiting `Import` expressions (by Repo Assist)
* [Dart] Fix `Array.compareWith` comparing lengths before elements, producing wrong results for arrays with common prefixes (fixes #2961)
* [Python] Fix unsafe option unwrapping in `DateTimeOffset.get_Offset` and regex replacements (by @dbrattli)
* [All] Replace unsafe option `.Value` unwrapping with safe alternatives in Python/Replacements.fs and Rust/Fable2Rust.fs (code scanning alerts IONIDE-006)
Expand Down
1 change: 1 addition & 0 deletions src/Fable.Compiler/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

* [All] Fix unnecessary object allocations during AST traversal when visiting `Import` expressions (by Repo Assist)
* [Dart] Fix `Array.compareWith` comparing lengths before elements, producing wrong results for arrays with common prefixes (fixes #2961)
* [Python] Fix unsafe option unwrapping in `DateTimeOffset.get_Offset` and regex replacements (by @dbrattli)
* [All] Replace unsafe option `.Value` unwrapping with safe alternatives in Python/Replacements.fs and Rust/Fable2Rust.fs (code scanning alerts IONIDE-006)
Expand Down
10 changes: 1 addition & 9 deletions src/Fable.Transforms/Transforms.Util.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1571,15 +1571,7 @@ module AST =
| Unresolved _ -> e // Unresolved expressions must be matched explicitly
| IdentExpr _ -> e
| TypeCast(e, t) -> TypeCast(f e, t)
| Import(info, t, r) ->
Import(
{ info with
Selector = info.Selector
Path = info.Path
},
t,
r
)
| Import _ -> e // Import has no sub-expressions to visit
| Extended(kind, r) ->
match kind with
| Curry(e, arity) -> Extended(Curry(f e, arity), r)
Expand Down
Loading