[Python] Fix modulo with negative numbers for bigint#4463
Merged
Conversation
Python's `%` operator uses floored remainder semantics while .NET uses truncated remainder. For bigint, `op_modulus` was using Python's `%` directly, so `-5I % 3I` returned `1` instead of `-2`. Fix by adjusting the result when dividend and divisor have different signs. int32 and int64 were already correct thanks to Rust wrapper types that implement truncated remainder via Rust's native `%` operator. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Python Type Checking Results (Pyright)
Excluded files with errors (4 files)These files have known type errors and are excluded from CI. Remove from
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bigintmodulo (%) with negative numbers returning Python floored remainder instead of .NET truncated remainder (fixes [Python] Modulo with negative numbers fails #4462)-5I % 3Inow correctly returns-2Iinstead of1Iintandint64were already correct thanks to Rust wrapper types whose__mod__uses Rust's native%(truncated)int,int64, andbigintTest plan
./build.sh test python --skip-fable-library-core— all 2107 tests pass🤖 Generated with Claude Code