chore(python): bump Fable.Python to 5.1.0#4571
Merged
Merged
Conversation
…ectly converted (#4560) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Dag Brattli <dag@brattli.net> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dbrattli
changed the title
Contributor
Python Type Checking Results (Pyright)
Excluded files with errors (4 files)These files have known type errors and are excluded from CI. Remove from
|
5.1.0 fixes the pyright type error in `getCases` (Json.fs) that broke the pyright CI job on 5.0.0 — see fable-compiler/Fable.Python#278. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dbrattli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fable.PythonNuGet reference intests/Python/Fable.Tests.Python.fsprojfrom 4.24.0 to 5.1.0.getCases(Json.fs) that was present in 5.0.0 and broke the pyright CI job — see Pyright type error in transpiled Json.fs:getCasesreturnsAny | list[Unknown]instead ofArray[str]Fable.Python#278.Test plan
dotnet restore tests/Python/Fable.Tests.Python.fsprojresolves cleanly./build.sh test python --skip-fable-library-core --type-check— Python tests: 2333 passeduv run pyright --project pyrightconfig.ci.json temp/tests/Python/ temp/fable-library-py/— 0 errors🤖 Generated with Claude Code