feat(all): add Compiler.is* target detection flags for conditional branching#4692
Merged
Conversation
Contributor
Python Type Checking Results (Pyright)
Excluded files with errors (4 files)These files have known type errors and are excluded from CI. Remove from
|
Member
Author
|
Hello @ncave, my memory is failing. In order to make, I don't remember how to do that, is it as simple as copying the result of |
Collaborator
|
@MangelMaxime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fable's conditional compilation relies on compiler directives. It is working fine but has a huge limitations.
In IDE, you often end up with no IDE support most of the compiler directives branches as the compiler directives is not set in the
fsproj. And even when setting it up in thefsprojthe experience is not always great depending on the IDEs.This PR is building on top of the existing foundation in Fable used for
Compiler.debugModeorCompiler.triggeredByDependency.The idea is that in Fable, if a
if ... then ... else ...structure is using boolean constant in their condition then Fable auto erase unreachable branches.This now allow us to write things like
which compiles to
JavaScript
Python
The only impact is on .NET where there will be a real runtime check against the boolean. This should be more than fast enough and people can use
Compiler.isDotnetto avoid having to check all the conditions.Summary
Thanks to these changes, we are now able to provide a better experience for interop/universal code.