Merge pull request #28 from dbrattli/chore/modernize-repo

chore: modernize repository with release-please and bug fixes

Author: dbrattli

.github/dependabot.yml

@@ -0,0 +1,11 @@
+# To get started with Dependabot version updates, you'll need to specify which
+# package ecosystems to update and where the package manifests are located.
+# Please see the documentation for all configuration options:
+# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"

.github/workflows/build-and-test.yml

@@ -2,26 +2,27 @@ name: Build and Test
 
 on:
   push:
-    branches: [ master ]
+    branches: [master]
   pull_request:
-    branches: [ master ]
+    branches: [master]
 
 jobs:
   build:
-
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v4
-    - name: Setup .NET Core
-      uses: actions/setup-dotnet@v4
-      with:
-        dotnet-version: 9.0.300
-    - name: Restore tools
-      run: dotnet tool restore
-    - name: Install dependencies
-      run: dotnet paket restore
-    - name: Build
-      run: dotnet build --configuration Release
-    - name: Test
-      run: dotnet test --verbosity normal
+      - uses: actions/checkout@v4
+
+      - name: Setup .NET Core
+        uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: 9.0.x
+
+      - name: Install just
+        uses: extractions/setup-just@v2
+
+      - name: Restore dependencies
+        run: just restore
+
+      - name: Build and test
+        run: just check

.github/workflows/conventional-pr-title.yml

@@ -0,0 +1,27 @@
+name: conventional-pr-title
+
+on:
+  pull_request:
+    types: [opened, edited, synchronize, reopened]
+    branches: [master]
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: amannn/action-semantic-pull-request@v5
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          types: |
+            feat
+            fix
+            chore
+            docs
+            style
+            refactor
+            perf
+            test
+            ci
+            build
+            revert

.github/workflows/publish.yml

@@ -0,0 +1,55 @@
+on:
+  push:
+    branches:
+      - master
+
+permissions:
+  contents: write
+  pull-requests: write
+
+name: Release Please
+
+jobs:
+  release-please:
+    runs-on: ubuntu-latest
+    outputs:
+      release_created: ${{ steps.release.outputs.release_created }}
+      tag_name: ${{ steps.release.outputs.tag_name }}
+    steps:
+      - uses: googleapis/release-please-action@v4
+        id: release
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+
+  publish:
+    needs: release-please
+    if: ${{ needs.release-please.outputs.release_created }}
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Setup .NET Core
+        uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: 9.0.x
+
+      - name: Install just
+        uses: extractions/setup-just@v2
+
+      - name: Restore dependencies
+        run: just restore
+
+      - name: Pack NuGet
+        env:
+          TAG_NAME: ${{ needs.release-please.outputs.tag_name }}
+        run: just pack-version ${TAG_NAME#v}
+
+      - name: Push Feliz.ViewEngine NuGet
+        run: dotnet nuget push src/bin/Release/*.nupkg -s https://api.nuget.org/v3/index.json -k ${{ secrets.NUGET_API_KEY }}
+        continue-on-error: false
+
+      - name: Push Feliz.Bulma.ViewEngine NuGet
+        run: dotnet nuget push Feliz.Bulma.ViewEngine/bin/Release/*.nupkg -s https://api.nuget.org/v3/index.json -k ${{ secrets.NUGET_API_KEY }}
+        continue-on-error: false

.github/workflows/release-please.yml

@@ -0,0 +1,3 @@
+{
+  ".": "1.0.0"
+}

.release-please-manifest.json

@@ -0,0 +1,25 @@
+# Changelog
+
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [1.0.0](https://github.com/dbrattli/Feliz.ViewEngine/compare/v0.27.0...v1.0.0) (unreleased)
+
+### Features
+
+* First stable release of Feliz.ViewEngine
+* Minimal event handler support in ReactElement DOM (not rendered, but available for inspection)
+
+### Bug Fixes
+
+* Fix Bulma.input properties being ignored (fixes #16, #22)
+* Relax FSharp.Core dependency constraint to allow modern versions (fixes #27)
+* Add Html.table overload for children elements (fixes #19)
+
+### Build
+
+* Add release-please for automated releases
+* Add conventional commit enforcement for PRs
+* Add dependabot for GitHub Actions updates

CHANGELOG.md

@@ -0,0 +1,82 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## Project Overview
+
+Feliz.ViewEngine is an F# library that renders the Feliz DSL to plain HTML or XML strings. It's designed for server-side rendering (SSR) scenarios like Giraffe web handlers, HTML email generation, or any case where HTML output is needed. The library has no dependencies and is Fable-compatible.
+
+## Build Commands
+
+```bash
+# Restore dependencies (uses Paket)
+dotnet restore
+
+# Build all projects
+dotnet build
+
+# Run tests
+dotnet test test/Tests.Feliz.ViewEngine.fsproj
+
+# Build specific project
+dotnet build src/Feliz.ViewEngine.fsproj
+```
+
+## Architecture
+
+### Core Types (src/ViewEngine.fs)
+
+The library defines its own `ReactElement` discriminated union (not Fable.React):
+
+```fsharp
+type IReactProperty =
+    | KeyValue of string * obj
+    | Children of ReactElement list
+    | Text of string
+
+type ReactElement =
+    | Element of string * IReactProperty list
+    | VoidElement of string * IReactProperty list  // self-closing like <br>, <img>
+    | TextElement of string
+    | Elements of ReactElement seq
+```
+
+The `Render` module converts these to strings via `htmlView`, `xmlView`, `htmlDocument`, or `xmlDocument`.
+
+### Interop Module (src/Interop.fs)
+
+Provides the API bridge between Feliz DSL and the ViewEngine types. Key functions:
+
+- `createElement` / `createVoidElement` - create elements with properties
+- `mkAttr` / `mkStyle` - create attributes and style properties
+- `createTextElement` / `createRawTextElement` - create text (escaped vs raw)
+
+### DSL Modules
+
+- `Html` (src/Html.fs) - HTML element functions (`Html.div`, `Html.p`, etc.)
+- `prop` (src/Properties.fs) - HTML properties (`prop.className`, `prop.style`, etc.)
+- `style` (src/Styles.fs) - CSS style properties
+- `React` (src/React.fs) - React-compatible utilities like `fragment`
+
+### Feliz.Bulma.ViewEngine Extension
+
+A port of Feliz.Bulma for server-side rendering, located in `Feliz.Bulma.ViewEngine/`.
+
+## Client/Server Code Sharing
+
+Use compiler directives to share views between client (Feliz) and server (Feliz.ViewEngine):
+
+```fsharp
+#if FABLE_COMPILER
+open Feliz
+#else
+open Feliz.ViewEngine
+#endif
+```
+
+## Key Differences from Feliz
+
+- Event handlers are stored in the DOM tree but ignored during rendering
+- `Html.none` returns an empty `TextElement` (not `unbox null`)
+- `Html.text` uses `createTextElement` (not unboxing)
+- HTML is escaped by default; use `Html.rawText` for unescaped content

CLAUDE.md

@@ -58,7 +58,7 @@ module Label =
 
 module Input =
     let inline propsWithType (cn:string) (typ: IReactProperty) (xs:IReactProperty list) =
-        Html.input [ typ; Helpers.combineClasses cn xs ]
+        Html.input [ typ; yield! Helpers.partitionClasses xs ||> (fun c p -> Helpers.combineClasses cn c :: p) ]
 
 module Textarea =
     let inline props (cn:string) (xs:IReactProperty list) = Html.textarea [ yield! Helpers.partitionClasses xs ||> (fun c p -> Helpers.combineClasses cn c :: p) ]

Feliz.Bulma.ViewEngine/ElementBuilders.fs

@@ -0,0 +1,42 @@
+# Feliz.ViewEngine build commands
+# Install just: https://github.com/casey/just
+
+src_path := "src"
+test_path := "test"
+bulma_path := "Feliz.Bulma.ViewEngine"
+
+# Default recipe - show available commands
+default:
+    @just --list
+
+# Clean build artifacts
+clean:
+    rm -rf {{src_path}}/obj {{test_path}}/obj {{bulma_path}}/obj
+    rm -rf {{src_path}}/bin {{test_path}}/bin {{bulma_path}}/bin
+
+# Restore all dependencies
+restore:
+    dotnet tool restore
+    dotnet paket restore
+
+# Build all projects
+build:
+    dotnet build --configuration Release
+
+# Run all tests
+test:
+    dotnet test {{test_path}}
+
+# Build and run tests
+check: build test
+
+# Create NuGet packages
+pack:
+    dotnet pack -c Release
+
+# Create NuGet packages with specific version (used in CI)
+pack-version version:
+    dotnet pack -c Release -p:PackageVersion={{version}}
+
+# Full setup and test
+setup: restore build test