-
Notifications
You must be signed in to change notification settings - Fork 65
Simplifies installation into vim with a plugin #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| if exists('g:loaded_rubyfmt') | ||
| finish | ||
| endif | ||
| let g:loaded_rubyfmt = 1 | ||
|
|
||
| let s:cpo_save = &cpo | ||
| set cpo&vim | ||
|
|
||
| " Path to the rubyfmt binary. Defaults to whatever is on $PATH; override in | ||
| " your vimrc, e.g. let g:rubyfmt_path = '/path/to/target/release/rubyfmt-main' | ||
| if !exists('g:rubyfmt_path') | ||
| let g:rubyfmt_path = 'rubyfmt' | ||
| endif | ||
|
|
||
| if !exists("s:rubyfmt_ac_set") | ||
| let s:rubyfmt_ac_set=1 | ||
| autocmd FileType ruby autocmd! BufWritePre <buffer> call rubyfmt#format() | ||
| endif | ||
|
|
||
| let &cpo = s:cpo_save | ||
| unlet s:cpo_save |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know about vim native packages, does this work for users who do not use plug?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm by no means a vim-plugin expert. My understanding is that tools like vim-plug, pathogen, etc, all handle the "fetching of code and putting it in place" while vim itself handles loading of the plugin through the autoload system or the packs system. Using vim-plug or pathogen benefits the user in that they're able to run one command and take updates to all the packages installed.
So the instructions for installing without a plugin tool are simply to download the plugin itself and place it in the correct place. The formatting and placement of the files within the plugin is standardized by vim itself.
That said, I tested these instructions both with the plug pattern and the native package and saw the tool work correctly in both cases.