minor fixes

Author: g-abilio

external/CMakeLists.txt

@@ -1,5 +1,5 @@
 if(BUILD_TESTING)
-  find_package(Catch2 QUIET)
+  find_package(Catch2 2.13.7 QUIET)
 
   if(NOT Catch2_FOUND)
     add_subdirectory(Catch2)

include/QtNodes/internal/Definitions.hpp

@@ -22,18 +22,17 @@ Q_NAMESPACE_EXPORT(NODE_EDITOR_PUBLIC)
  * Constants used for fetching QVariant data from GraphModel.
  */
     enum class NodeRole {
-        Type = 0,             ///< Type of the current node, usually a string.
-        Position = 1,         ///< `QPointF` positon of the node on the scene.
-        Size = 2,             ///< `QSize` for resizable nodes.
-        CaptionVisible = 3,   ///< `bool` for caption visibility.
-        Caption = 4,          ///< `QString` for node caption.
-        Style = 5,            ///< Custom NodeStyle as QJsonDocument
-        InternalData = 6,     ///< Node-stecific user data as QJsonObject
-        InPortCount = 7,      ///< `unsigned int`
-        OutPortCount = 9,     ///< `unsigned int`
-        Widget = 10,          ///< Optional `QWidget*` or `nullptr`
-        ValidationState = 11, ///< Enum NodeValidationState of the node
-        ProcessingStatus = 12 ///< Enum NodeProcessingStatus of the node
+        Type = 0,            ///< Type of the current node, usually a string.
+        Position = 1,        ///< `QPointF` positon of the node on the scene.
+        Size = 2,            ///< `QSize` for resizable nodes.
+        CaptionVisible = 3,  ///< `bool` for caption visibility.
+        Caption = 4,         ///< `QString` for node caption.
+        Style = 5,           ///< Custom NodeStyle as QJsonDocument
+        InternalData = 6,    ///< Node-stecific user data as QJsonObject
+        InPortCount = 7,     ///< `unsigned int`
+        OutPortCount = 9,    ///< `unsigned int`
+        Widget = 10,         ///< Optional `QWidget*` or `nullptr`
+        ValidationState = 11 ///< Enum NodeValidationState of the node
     };
 Q_ENUM_NS(NodeRole)
 

src/DefaultHorizontalNodeGeometry.cpp

@@ -55,12 +55,6 @@ void DefaultHorizontalNodeGeometry::recomputeSize(NodeId const nodeId) const
     height += _portSpasing; // space above caption
     height += _portSpasing; // space below caption
 
-    QVariant var = _graphModel.nodeData(nodeId, NodeRole::ProcessingStatus);
-    auto processingStatusValue = var.value<int>();
-
-    if (processingStatusValue != 0)
-        height += 20;
-
     unsigned int inPortWidth = maxPortsTextAdvance(nodeId, PortType::In);
     unsigned int outPortWidth = maxPortsTextAdvance(nodeId, PortType::Out);