refactor: Simplify v2 recommender by arajkumar · Pull Request #265 · fabric8-analytics/f8a-server-backbone

arajkumar · 2020-12-31T09:30:20Z

This PR simplifies the v2 recommender implementation. Here is a flow,

Call respective insight service
Get details(github, latest_version,..) for the recommended packages(step-1) from graph
Prepare response (version selection is based on latest_non_cve_version from Package node)

Note: Package will be dropped off from the recommendation incase if latest_non_cve_version is empty

Fixes https://issues.redhat.com/browse/APPAI-1694

…ring

codecov-io · 2020-12-31T09:31:41Z

Codecov Report

Merging #265 (723841e) into master (1367cf9) will increase coverage by 3.12%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
+ Coverage   90.67%   93.80%   +3.12%     
==========================================
  Files          11        8       -3     
  Lines        1716      936     -780     
==========================================
- Hits         1556      878     -678     
+ Misses        160       58     -102

Impacted Files	Coverage Δ
src/rest_api.py	`88.46% <75.86%> (+2.14%)`	⬆️
src/settings.py	`100.00% <100.00%> (ø)`
src/utils.py	`86.89% <100.00%> (ø)`
src/v2/models.py	`100.00% <100.00%> (ø)`
src/v2/recommender.py	`100.00% <100.00%> (+10.45%)`	⬆️
src/v2/stack_aggregator.py	`92.37% <100.00%> (+1.27%)`	⬆️
src/recommender.py
src/stack_aggregator.py
src/__init__.py
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1367cf9...723841e. Read the comment docs.

arajkumar · 2021-01-05T14:46:12Z

/build-image

github-actions · 2021-01-05T14:46:43Z

🧪 CI has Started Image Build

github-actions · 2021-01-05T14:49:21Z

✌️ Image Build Successfull @arajkumar, Avaliable at: ghcr.io/fabric8-analytics/f8a-server-backbone/fabric8-analytics-f8a-server-backbone:SNAPSHOT-PR-265

arajkumar · 2021-01-06T07:57:48Z

/build-image

github-actions · 2021-01-06T07:58:16Z

🧪 CI has Started Image Build

github-actions · 2021-01-06T08:01:01Z

✌️ Image Build Successfull @arajkumar, Avaliable at: ghcr.io/fabric8-analytics/f8a-server-backbone/fabric8-analytics-f8a-server-backbone:SNAPSHOT-PR-265

prashbnair

Looks good, just a few minor issues.

dgpatelgit

lgtm

arajkumar · 2021-01-07T09:34:07Z

/build-image

github-actions · 2021-01-07T09:34:39Z

🧪 CI has Started Image Build

github-actions · 2021-01-07T09:37:24Z

✌️ Image Build Successfull @arajkumar, Avaliable at: ghcr.io/fabric8-analytics/f8a-server-backbone/fabric8-analytics-f8a-server-backbone:SNAPSHOT-PR-265

arajkumar · 2021-01-07T09:56:47Z

/build-image

github-actions · 2021-01-07T09:57:16Z

🧪 CI has Started Image Build

github-actions · 2021-01-07T10:00:03Z

✌️ Image Build Successfull @arajkumar, Avaliable at: ghcr.io/fabric8-analytics/f8a-server-backbone/fabric8-analytics-f8a-server-backbone:SNAPSHOT-PR-265

This fixes the regression introduced by #265 by adding an empty entry for golang recommendation.

codecov-commenter · 2026-04-03T11:49:17Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 95.23810% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.80%. Comparing base (1367cf9) to head (db76d1f).
⚠️ Report is 32 commits behind head on master.

Files with missing lines	Patch %	Lines
src/rest_api.py	75.86%	7 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
+ Coverage   90.67%   93.80%   +3.12%     
==========================================
  Files          11        8       -3     
  Lines        1716      936     -780     
==========================================
- Hits         1556      878     -678     
+ Misses        160       58     -102

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arajkumar added 2 commits December 31, 2020 14:49

refactor: Simplify v2 recommender

fd1be44

Merge remote-tracking branch 'origin/master' into recommender-refacto…

bf86201

…ring

arajkumar added 6 commits January 5, 2021 12:48

completed refactoring

3af24c1

fix: Tests after module rename

b0efa53

fix: linters and vultures

db5c9b6

Add missing bits

b802d39

fix: Convert to utc rather than local for latest_release_duration

2deed4d

Remove unpopulated field

73b4496

arajkumar added 3 commits January 6, 2021 12:25

fix: Split test data into separate module

d5346ed

fix: treat missing latest_non_cve_version as non vulnerable

ce10e6d

fix: linter

ac3c537

arajkumar marked this pull request as ready for review January 6, 2021 08:18

arajkumar self-assigned this Jan 6, 2021

arajkumar requested review from dgpatelgit and prashbnair and removed request for prashbnair January 6, 2021 08:21

arajkumar commented Jan 6, 2021

View reviewed changes

Comment thread scripts/entrypoint.sh

arajkumar commented Jan 6, 2021

View reviewed changes

Comment thread src/rest_api.py

arajkumar commented Jan 6, 2021

View reviewed changes

Comment thread src/v2/models.py

arajkumar commented Jan 6, 2021

View reviewed changes

Comment thread src/v2/recommender.py

dgpatelgit reviewed Jan 6, 2021

View reviewed changes

Comment thread src/v2/stack_aggregator.py

Comment thread src/v2/recommender.py

prashbnair requested changes Jan 6, 2021

View reviewed changes

Comment thread src/rest_api.py

Comment thread src/v2/recommender.py Outdated

Comment thread src/v2/recommender.py Outdated

Comment thread src/v2/recommender.py

fix: Review comments

723841e

arajkumar requested review from dgpatelgit and prashbnair January 6, 2021 17:36

arajkumar added 2 commits January 6, 2021 23:21

fix: Refactor settings

3ced6d2

fix: linter

c6a8ee0

arajkumar commented Jan 7, 2021

View reviewed changes

Comment thread src/v2/models.py

prashbnair approved these changes Jan 7, 2021

View reviewed changes

dgpatelgit approved these changes Jan 7, 2021

View reviewed changes

fix: Add usage_outliers until it is removed from api server

db76d1f

arajkumar force-pushed the recommender-refactoring branch from a9bac47 to db76d1f Compare January 7, 2021 09:55

arajkumar merged commit 8991da0 into fabric8-analytics:master Jan 7, 2021

arajkumar mentioned this pull request Jan 7, 2021

fix: Add empty recommendation entry for golang #267

Merged

arajkumar added a commit that referenced this pull request Jan 7, 2021

fix: Add empty recommendation entry for golang (#267)

77459c0

This fixes the regression introduced by #265 by adding an empty entry for golang recommendation.

arajkumar mentioned this pull request Jan 12, 2021

[backbone] Move v2 recommender refactoring to prod openshiftio/saas-analytics#914

Merged

Conversation

arajkumar commented Dec 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Dec 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

arajkumar commented Jan 5, 2021

Uh oh!

github-actions Bot commented Jan 5, 2021

Uh oh!

github-actions Bot commented Jan 5, 2021

Uh oh!

arajkumar commented Jan 6, 2021

Uh oh!

github-actions Bot commented Jan 6, 2021

Uh oh!

github-actions Bot commented Jan 6, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

prashbnair left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dgpatelgit left a comment

Choose a reason for hiding this comment

Uh oh!

arajkumar commented Jan 7, 2021

Uh oh!

github-actions Bot commented Jan 7, 2021

Uh oh!

github-actions Bot commented Jan 7, 2021

Uh oh!

arajkumar commented Jan 7, 2021

Uh oh!

github-actions Bot commented Jan 7, 2021

Uh oh!

github-actions Bot commented Jan 7, 2021

Uh oh!

codecov-commenter commented Apr 3, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

arajkumar commented Dec 31, 2020 •

edited

Loading

codecov-io commented Dec 31, 2020 •

edited

Loading