Skip to content

fix: Use ingestion API for unknown package flow#266

Merged
jparsai merged 9 commits into
fabric8-analytics:masterfrom
jparsai:jobs
Jan 11, 2021
Merged

fix: Use ingestion API for unknown package flow#266
jparsai merged 9 commits into
fabric8-analytics:masterfrom
jparsai:jobs

Conversation

@jparsai

@jparsai jparsai commented Jan 4, 2021

Copy link
Copy Markdown
Contributor

Description

Using Ingestion API to trigger worker flow instead of embedded code, also enabled Golang ingestion jobs.

Comment thread requirements.txt
Comment thread tests/requirements.txt
Comment thread tests/requirements.txt
@codecov-io

codecov-io commented Jan 4, 2021

Copy link
Copy Markdown

Codecov Report

Merging #266 (cb2518b) into master (7556cf4) will increase coverage by 2.10%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   91.73%   93.84%   +2.10%     
==========================================
  Files          11        8       -3     
  Lines        1573      942     -631     
==========================================
- Hits         1443      884     -559     
+ Misses        130       58      -72     
Impacted Files Coverage Δ
src/v2/stack_aggregator.py 92.50% <88.23%> (+0.12%) ⬆️
src/__init__.py
src/recommender.py
src/stack_aggregator.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7556cf4...cb2518b. Read the comment docs.

Comment thread src/v2/stack_aggregator.py Outdated
Comment thread requirements.in Outdated
@arajkumar arajkumar changed the title fix: [SA] Trigger unknown package using Ingestion API. fix: Use ingestion API for unknown package flow Jan 4, 2021
Comment thread src/v2/stack_aggregator.py Outdated
Comment thread src/v2/stack_aggregator.py Outdated

@deepak1725 deepak1725 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, wait for others

Comment thread requirements.in
Comment thread src/v2/stack_aggregator.py Outdated
Comment thread src/v2/stack_aggregator.py Outdated

@arajkumar arajkumar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.84%. Comparing base (7556cf4) to head (cb2518b).
⚠️ Report is 29 commits behind head on master.

Files with missing lines Patch % Lines
src/v2/stack_aggregator.py 88.23% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   91.73%   93.84%   +2.10%     
==========================================
  Files          11        8       -3     
  Lines        1573      942     -631     
==========================================
- Hits         1443      884     -559     
+ Misses        130       58      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants