Skip to content

chore: Unify internal service host config names#269

Merged
arajkumar merged 9 commits into
fabric8-analytics:masterfrom
arajkumar:cleanup-service-host
Jan 12, 2021
Merged

chore: Unify internal service host config names#269
arajkumar merged 9 commits into
fabric8-analytics:masterfrom
arajkumar:cleanup-service-host

Conversation

@arajkumar
Copy link
Copy Markdown
Contributor

Prior to this PR, service config values are spread across two variables, host-name & port. This is less flexible because you can't override the scheme.(e.g. http to https).

Also no option to override individual insight service ports. e.g. useful while running on docker-compose.

This PR unifies all service host base url under the following pattern(*_base_url).
e.g.

PYPI_INSIGHTS_BASE_URL=http://f8a-pypi-insights:6006

Note: There is no functionality affected.

@arajkumar arajkumar self-assigned this Jan 8, 2021
@arajkumar
Copy link
Copy Markdown
Contributor Author

/build-image

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 8, 2021

🧪 CI has Started Image Build

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 8, 2021

✌️ Image Build Successfull @arajkumar, Avaliable at: ghcr.io/fabric8-analytics/f8a-server-backbone/fabric8-analytics-f8a-server-backbone:SNAPSHOT-PR-269

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #269 (4cbe322) into master (b66e25e) will increase coverage by 1.95%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   91.75%   93.71%   +1.95%     
==========================================
  Files          11        8       -3     
  Lines        1577      938     -639     
==========================================
- Hits         1447      879     -568     
+ Misses        130       59      -71     
Impacted Files Coverage Δ
src/rest_api.py 88.46% <100.00%> (ø)
src/settings.py 100.00% <100.00%> (ø)
src/utils.py 85.36% <100.00%> (-1.53%) ⬇️
src/v2/license_service.py 96.29% <100.00%> (+0.04%) ⬆️
src/v2/recommender.py 100.00% <100.00%> (ø)
src/v2/stack_aggregator.py 93.13% <100.00%> (+0.63%) ⬆️
src/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b66e25e...4cbe322. Read the comment docs.

Comment thread src/settings.py
Comment thread src/settings.py
Comment thread src/v2/stack_aggregator.py
Comment thread src/settings.py
@arajkumar arajkumar requested a review from prashbnair January 11, 2021 11:52
Comment thread src/v2/stack_aggregator.py
@arajkumar arajkumar requested a review from prashbnair January 11, 2021 13:55
Copy link
Copy Markdown
Contributor

@dgpatelgit dgpatelgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.68%. Comparing base (b66e25e) to head (34902af).
⚠️ Report is 28 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   91.75%   93.68%   +1.93%     
==========================================
  Files          11        8       -3     
  Lines        1577      935     -642     
==========================================
- Hits         1447      876     -571     
+ Misses        130       59      -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants