chore: Unify internal service host config names#269
Conversation
|
/build-image |
|
✌️ Image Build Successfull @arajkumar, Avaliable at: |
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
==========================================
+ Coverage 91.75% 93.71% +1.95%
==========================================
Files 11 8 -3
Lines 1577 938 -639
==========================================
- Hits 1447 879 -568
+ Misses 130 59 -71
Continue to review full report at Codecov.
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
==========================================
+ Coverage 91.75% 93.68% +1.93%
==========================================
Files 11 8 -3
Lines 1577 935 -642
==========================================
- Hits 1447 876 -571
+ Misses 130 59 -71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Prior to this PR, service config values are spread across two variables, host-name & port. This is less flexible because you can't override the scheme.(e.g. http to https).
Also no option to override individual insight service ports. e.g. useful while running on docker-compose.
This PR unifies all service host base url under the following pattern(*_base_url).
e.g.
Note: There is no functionality affected.