Skip to content

fix: Ignore packages with -1 as version from recommendation list#268

Merged
arajkumar merged 2 commits into
fabric8-analytics:masterfrom
arajkumar:ignore-invalid-version
Jan 8, 2021
Merged

fix: Ignore packages with -1 as version from recommendation list#268
arajkumar merged 2 commits into
fabric8-analytics:masterfrom
arajkumar:ignore-invalid-version

Conversation

@arajkumar

Copy link
Copy Markdown
Contributor

Supplement to #267 , ignores packages which has version as -1.

e.g. pypi, wsgiref has following properties.

{
    "requestId": "fd8f06ef-2b52-46aa-84c9-2975dd7149ed",
    "status": {
        "message": "",
        "code": 200,
        "attributes": {}
    },
    "result": {
        "data": [
            {
                "gh_issues_last_year_closed": [
                    -1
                ],
                "gh_issues_last_month_opened": [
                    -1
                ],
                "gh_prs_last_year_closed": [
                    -1
                ],
                "last_updated": [
                    1.53930382643E9
                ],
                "libio_usedby": [
                    "NUKnightLab/TimelineJS:8383",
                    "NUKnightLab/TimelineJS:8385",
                    "amvtek/EventSource:107",
                    "capitalone/cloud-custodian:879",
                    "capitalone/cloud-custodian:887",
                    "cayleygraph/cayley:10105",
                    "cayleygraph/cayley:10111",
                    "jeffh/Fox:599",
                    "lepture/flask-wtf:619",
                    "mobolic/facebook-sdk:1984",
                    "mobolic/facebook-sdk:1985",
                    "odoo/odoo:6888",
                    "odoo/odoo:6895",
                    "paypal/PayPal-Python-SDK:413",
                    "stormpath/express-stormpath:299"
                ],
                "gh_prs_last_month_closed": [
                    -1
                ],
                "ecosystem": [
                    "pypi"
                ],
                "libio_total_releases": [
                    "3"
                ],
                "vertex_label": [
                    "Package"
                ],
                "libio_dependents_repos": [
                    "35336"
                ],
                "gh_issues_last_year_opened": [
                    -1
                ],
                "gh_issues_last_month_closed": [
                    -1
                ],
                "gh_prs_last_year_opened": [
                    -1
                ],
                "libio_dependents_projects": [
                    "0"
                ],
                "latest_version": [
                    "-1"
                ],
                "name": [
                    "wsgiref"
                ],
                "libio_latest_version": [
                    "0.1.2"
                ],
                "tokens": [
                    "wsgiref"
                ],
                "package_relative_used": [
                    "not used"
                ],
                "libio_latest_release": [
                    1.150084534E9
                ],
                "gh_stargazers": [
                    -1
                ],
                "gh_forks": [
                    -1
                ],
                "package_dependents_count": [
                    -1
                ],
                "gh_prs_last_month_opened": [
                    -1
                ]
            }
        ],
        "meta": {}
    }
}

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #268 (c2c3c60) into master (77459c0) will increase coverage by 2.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
+ Coverage   91.73%   93.81%   +2.07%     
==========================================
  Files          11        8       -3     
  Lines        1572      937     -635     
==========================================
- Hits         1442      879     -563     
+ Misses        130       58      -72     
Impacted Files Coverage Δ
src/v2/recommender.py 100.00% <100.00%> (ø)
src/stack_aggregator.py
src/__init__.py
src/recommender.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77459c0...c2c3c60. Read the comment docs.

Comment thread src/v2/recommender.py Outdated
Comment thread src/v2/recommender.py Outdated
@arajkumar arajkumar force-pushed the ignore-invalid-version branch from dbbadfe to ff799cf Compare January 8, 2021 07:12
@arajkumar arajkumar requested a review from dgpatelgit January 8, 2021 07:13

@dgpatelgit dgpatelgit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants